[codex] Fix v1.12 Python SDK overview examples#243
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
There was a problem hiding this comment.
Pull request overview
This PR updates the v1.12.x Python SDK documentation to match the APIs shipped in openmetadata-ingestion==1.12.6.2, replacing stale examples (older paging/list/update/patch patterns and singular facades) with the current plural facade + configure(...) flow and adding clarification where the generated API reference documents lower-level ingestion client mixins.
Changes:
- Refresh Python SDK overview + guides to use plural facades (
Tables,Tags,MLModels, etc.),configure(...),list_all(), keyword-basedlist(...), andupdate(entity). - Update Tags/Lineage/ML Model docs to reflect current workflows (tagging tables/columns, explicit lineage edges, ML model CRUD + lineage).
- Add “Tip” callouts in generated API reference pages to clearly distinguish lower-level
metadata.ingestion.ometamixin methods frommetadata.sdkfacades; fix minor copy/typos and pin install version.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| v1.12.x/api-reference/sdk/python/overview.mdx | Rewrites overview examples to plural facades, configure, new list/pagination/update patterns, and clarifies facade scope. |
| v1.12.x/api-reference/sdk/python/ingestion/tags.mdx | Updates tagging walkthrough to SDK configure + facade CRUD and current tag/column-tag flows. |
| v1.12.x/api-reference/sdk/python/ingestion/lineage.mdx | Fixes copy and updates lineage examples to current ID/root handling + client().ometa where facades don’t exist. |
| v1.12.x/api-reference/sdk/python/entities/ml-model.mdx | Updates ML model guide to use MLModels facade + explicit lineage edges; refreshes requirements notes. |
| v1.12.x/api-reference/sdk/python/build-connector/bulk-sink.mdx | Fixes minor copy/formatting in description and link section. |
| v1.12.x/api-reference/sdk/python/api-reference/patch-mixin.mdx | Adds clarification tip that mixin methods are lower-level metadata.ingestion.ometa APIs, not metadata.sdk facades. |
| v1.12.x/api-reference/sdk/python/api-reference/mlmodel-mixin.mdx | Adds clarification tip pointing to MLModels + metadata.sdk.api.Lineage for current SDK surface. |
| v1.12.x/api-reference/sdk/python/api-reference/lineage-mixin.mdx | Adds clarification tip about metadata.sdk.api.Lineage vs lower-level lineage parsing APIs. |
| v1.12.x/api-reference/sdk/python/api-reference.mdx | Adds a top-level tip clarifying the generated reference is for metadata.ingestion.ometa, and links to facade docs. |
| v1.12.x/api-reference/sdk/python.mdx | Updates install pin, switches to configure, modernizes examples (Pydantic v2 dump, owners, delete ID/root). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Use in other entity creation | ||
| if ref: | ||
| print(f"Table reference ID: {ref.id}") | ||
| print(f"Table reference ID: {ref['id']}") |
|
One small SDK accuracy note on the new low-level client guidance: the doc says to use the OpenMetadata client returned by Could we make that explicit, for example “use |
|
One SDK accuracy issue I noticed while validating against the current
Could we change this paragraph to say |
What changed
configure(...)connection flow.auto_paging_iterable(),TableListParams,update(id, entity), singular facade, and unavailable facade patch examples withlist_all(), keyword-basedlist(...),update(entity), and lower-levelclient().ometawhere needed.metadata.ingestion.ometaAPI reference pages so mixin methods are not mistaken for currentmetadata.sdkfacade methods.Why
The published v1.12.x Python SDK docs contained examples that do not match the Python SDK shipped in
openmetadata-ingestion==1.12.6.2, causing import and attribute errors for users following the docs.Validation
openmetadata-ingestion==1.12.6.2in a temporary Python 3.12 venv and validated the documented SDK paths againsthttps://sandbox-beta.open-metadata.org/apiusing a temporary script.Tables.list,Tables.list_all,Tables.retrieve_by_name,Tables.update(entity), owner updates viaEntityReferenceList, table tags, column tags, table lineage, pipeline lineage details,MLModels, lower-level service creation throughclient().ometa, and cleanup for all temporary entities.ast.parsewhere applicable.git diff --check.metadata.ingestion.ometaAPI reference pages and now include explicit clarification notes.