Skip to content

[1.13] QuestDB Docs#211

Open
akashverma0786 wants to merge 1 commit into
open-metadata:mainfrom
akashverma0786:Questdb-docs
Open

[1.13] QuestDB Docs#211
akashverma0786 wants to merge 1 commit into
open-metadata:mainfrom
akashverma0786:Questdb-docs

Conversation

@akashverma0786
Copy link
Copy Markdown
Contributor

No description provided.

@ayush-shah
Copy link
Copy Markdown
Member

Code review note from May 5, 2026: blocking before merge.

Findings:

  • The PR adds QuestDB docs, but the current OpenMetadata main checkout does not contain a QuestDB connector/schema (no questdbConnection or ingestion source found). Please confirm the matching connector code is merged into the target release before publishing the docs.
  • The PR adds v1.13.x-SNAPSHOT QuestDB pages and docs.json navigation, but does not add QuestDB to the v1.13 connector list snippet. The v1.12 connector list is updated, so the latest connector grid would omit QuestDB.
  • The PR currently has no status checks showing in GitHub; Mintlify validation should run before merge.

Recommendation: hold merge until the connector code/release dependency is confirmed, the v1.13 connector list is updated, and validation runs.

@ayush-shah ayush-shah changed the title QuestDB Docs [1.13] QuestDB Docs May 11, 2026
Copy link
Copy Markdown
Member

@ayush-shah ayush-shah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revalidated current head 851b8beb.

Validation:

  • rtk mint broken-links: passed.
  • git diff --check origin/main...refs/remotes/pr/211: clean.
  • Cross-check: local Collate/OpenMetadata product checkouts still do not contain a QuestDB connector/schema, and snippets/v1.13.x-SNAPSHOT/connectors/database/connectors-list.mdx is still not updated even though v1.13 docs/navigation pages were added.

The May 5 blocking note still applies: please confirm the connector code/release dependency and add QuestDB to the v1.13 connector list before merge.

@ayush-shah
Copy link
Copy Markdown
Member

I revalidated this against the refreshed OpenMetadata source. The QuestDB connector itself now exists in the main codebase, so the earlier “no connector/schema” concern is stale.

There are still a couple of doc-side items to tighten before merge:

  • The YAML examples use source.type: questDB. The ingestion examples and workflow source names are conventionally lowercase (for example, source.type: exasol while serviceConnection.config.type: Exasol). Could we make this source.type: questdb in both versioned YAML pages and keep only the connection config type as QuestDB?
  • The PR adds QuestDB to snippets/v1.12.x/connectors/database/connectors-list.mdx, but I do not see the matching v1.13 connector-card entry. Since this PR also registers v1.13.x-SNAPSHOT/connectors/database/questdb in docs.json, the v1.13 database connector overview should expose the card too.

After those are fixed, this looks source-backed from the current connector implementation.

@ayush-shah
Copy link
Copy Markdown
Member

Update after revalidating against latest OpenMetadata main: the QuestDB connector/source now exists in the codebase, so the old “connector missing” concern is no longer a blocker.

I still see one docs-side discoverability gap: this PR adds QuestDB to docs.json and the v1.12 database connector list, but I don’t see a QuestDB card added to the v1.13 database connector-list snippet. Could we add the v1.13 card as well so the new v1.13 QuestDB pages are reachable from the Database Services overview once the versioned connector-list import is aligned?

@ayush-shah
Copy link
Copy Markdown
Member

One correction after checking the release line more closely: QuestDB exists on current main, but I could not find it in the v1.12 branches/releases I checked (origin/1.12.8, origin/1.12.9). That means the v1.12.x pages/navigation in this PR look premature unless the connector is also being backported to v1.12. Could we either remove the v1.12.x QuestDB docs/nav from this PR, or link the matching v1.12 connector backport?

A couple of the earlier doc-side items still apply as well:

  • The YAML examples should use source.type: questdb; the source example in OpenMetadata uses lowercase questdb, while serviceConnection.config.type is QuestDB.
  • The generic <Lineage /> snippet enables query/stored-procedure lineage settings, but the QuestDB connector/schema appears to support view lineage only (supportsViewLineageExtraction). Could we make the QuestDB example/note specific to view lineage so users do not enable unsupported lineage modes?
  • Please also add the matching v1.13 connector-list card if the v1.13 pages remain registered in docs.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants