Skip to content

Chore(UI): Add pretty and eslint for openmetadata-ui-core-components for code quality#26686

Open
aniketkatkar97 wants to merge 19 commits intomainfrom
core-components-pretty
Open

Chore(UI): Add pretty and eslint for openmetadata-ui-core-components for code quality#26686
aniketkatkar97 wants to merge 19 commits intomainfrom
core-components-pretty

Conversation

@aniketkatkar97
Copy link
Member

@aniketkatkar97 aniketkatkar97 commented Mar 23, 2026

  • I worked on adding Prettier and ESLint configuration for openmetadata-ui-core-components to improve code quality and match it with openmetadata-ui.
  • Fixed all the ESLint errors and warnings.

@aniketkatkar97 aniketkatkar97 self-assigned this Mar 23, 2026
Copilot AI review requested due to automatic review settings March 23, 2026 07:14
@github-actions github-actions bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Mar 23, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Prettier + ESLint tooling to openmetadata-ui-core-components and applies the resulting formatting updates across the UI source to align code quality with openmetadata-ui.

Changes:

  • Added ESLint flat config (eslint.config.mjs) and Prettier config/ignore files.
  • Updated package.json with lint/format scripts and devDependencies for ESLint/Prettier.
  • Ran formatting across TS/TSX/CSS sources (quotes, prop ordering, line wrapping, etc.).

Reviewed changes

Copilot reviewed 130 out of 146 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
openmetadata-ui-core-components/src/main/resources/ui/src/theme/button-theme.ts Formatting-only (import wrapping) to match Prettier style
openmetadata-ui-core-components/src/main/resources/ui/src/styles/typography.css Prettier formatting (quote normalization, content quotes)
openmetadata-ui-core-components/src/main/resources/ui/src/styles/storybook.css Prettier formatting for CSS imports
openmetadata-ui-core-components/src/main/resources/ui/src/styles/globals.css Prettier formatting (imports, font/shadow var wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/stories/Typography.stories.tsx Prettier formatting (types, JSX wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/stories/Tooltip.stories.tsx Prettier formatting (quotes, prop ordering, JSX wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/stories/Toggle.stories.tsx Prettier formatting (quotes, prop ordering)
openmetadata-ui-core-components/src/main/resources/ui/src/stories/Tags.stories.tsx Prettier formatting (quotes, JSX wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/stories/Slider.stories.tsx Prettier formatting (JSX wrapping, prop ordering)
openmetadata-ui-core-components/src/main/resources/ui/src/stories/SlideoutMenu.stories.tsx Prettier formatting (quotes, JSX wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/stories/Select.stories.tsx Prettier formatting (prop ordering, JSX wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/stories/RadioButtons.stories.tsx Prettier formatting (import wrapping, prop ordering)
openmetadata-ui-core-components/src/main/resources/ui/src/stories/ProgressIndicators.stories.tsx Prettier formatting (import wrapping, JSX wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/stories/Popover.stories.tsx Prettier formatting (imports, prop ordering, JSX wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/stories/Pagination.stories.tsx Prettier formatting (imports, JSX wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/stories/Input.stories.tsx Prettier formatting (imports, JSX wrapping, prop ordering)
openmetadata-ui-core-components/src/main/resources/ui/src/stories/Grid.stories.tsx Prettier formatting (imports, JSX wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/stories/FeaturedIcon.stories.tsx Prettier formatting (argTypes wrapping, JSX wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/stories/Dropdown.stories.tsx Prettier formatting (imports, prop ordering)
openmetadata-ui-core-components/src/main/resources/ui/src/stories/DotIcon.stories.tsx Prettier formatting (imports, quotes)
openmetadata-ui-core-components/src/main/resources/ui/src/stories/Divider.stories.tsx Prettier formatting (imports, JSX wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/stories/CloseButton.stories.tsx Prettier formatting (imports, quotes)
openmetadata-ui-core-components/src/main/resources/ui/src/stories/CheckboxIcons.stories.tsx Prettier formatting (imports, quotes)
openmetadata-ui-core-components/src/main/resources/ui/src/stories/Checkbox.stories.tsx Prettier formatting (imports, prop ordering)
openmetadata-ui-core-components/src/main/resources/ui/src/stories/Card.stories.tsx Prettier formatting (JSX wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/stories/ButtonUtility.stories.tsx Prettier formatting (imports, prop ordering)
openmetadata-ui-core-components/src/main/resources/ui/src/stories/ButtonGroup.stories.tsx Prettier formatting (import wrapping, JSX wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/stories/BaseButton.stories.tsx Prettier formatting (imports, JSX wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/stories/Avatar.stories.tsx Prettier formatting (imports, prop ordering, JSX wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/hooks/use-resize-observer.ts Prettier formatting (quotes/indentation)
openmetadata-ui-core-components/src/main/resources/ui/src/hooks/use-clipboard.ts Prettier formatting (quotes/spacing)
openmetadata-ui-core-components/src/main/resources/ui/src/hooks/use-breakpoint.ts Prettier formatting (quotes/wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/constants/Tabs.constants.ts Prettier formatting (quotes/object wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/components/foundations/typography.tsx Prettier formatting (quotes, export formatting)
openmetadata-ui-core-components/src/main/resources/ui/src/components/foundations/dot-icon.tsx Prettier formatting (JSX attribute wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/components/checkbox-icons.tsx Prettier formatting (JSX attribute ordering)
openmetadata-ui-core-components/src/main/resources/ui/src/components/base/video-player/play-button-icon.tsx Prettier formatting (quotes, indentation)
openmetadata-ui-core-components/src/main/resources/ui/src/components/base/video-player/icons.tsx Prettier formatting (JSX attribute ordering)
openmetadata-ui-core-components/src/main/resources/ui/src/components/base/tooltip/tooltip.tsx Prettier formatting (imports, quotes, prop ordering)
openmetadata-ui-core-components/src/main/resources/ui/src/components/base/textarea/textarea.tsx Prettier formatting (imports, JSX & style blocks)
openmetadata-ui-core-components/src/main/resources/ui/src/components/base/tags/base-components/tag-close-x.tsx Prettier formatting (imports, JSX & prop ordering)
openmetadata-ui-core-components/src/main/resources/ui/src/components/base/tags/base-components/tag-checkbox.tsx Prettier formatting (quotes, JSX attribute ordering)
openmetadata-ui-core-components/src/main/resources/ui/src/components/base/slider/slider.tsx Prettier formatting (imports, wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/components/base/skeleton/skeleton.tsx Prettier formatting (quotes, prop ordering)
openmetadata-ui-core-components/src/main/resources/ui/src/components/base/select/select-native.tsx Prettier formatting (imports, JSX attribute ordering)
openmetadata-ui-core-components/src/main/resources/ui/src/components/base/select/select-item.tsx Prettier formatting (imports, wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/components/base/select/popover.tsx Prettier formatting (imports, quotes)
openmetadata-ui-core-components/src/main/resources/ui/src/components/base/progress-indicators/simple-circle.tsx Prettier formatting (wrapping/attribute ordering)
openmetadata-ui-core-components/src/main/resources/ui/src/components/base/progress-indicators/progress-indicators.tsx Prettier formatting (typing/JSX wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/components/base/input/label.tsx Prettier formatting (imports, JSX wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/components/base/input/hint-text.tsx Prettier formatting (quotes, prop ordering)
openmetadata-ui-core-components/src/main/resources/ui/src/components/base/grid/grid.tsx Prettier formatting (typing, wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/components/base/form/hook-form.tsx Prettier formatting (typing, wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/components/base/form/form.tsx Prettier formatting (quotes)
openmetadata-ui-core-components/src/main/resources/ui/src/components/base/file-upload-trigger/file-upload-trigger.tsx Prettier formatting (imports, wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/components/base/divider/divider.tsx Prettier formatting (quotes, JSX ordering)
openmetadata-ui-core-components/src/main/resources/ui/src/components/base/card/card.tsx Prettier formatting (quotes, wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/components/base/buttons/close-button.tsx Prettier formatting (imports, JSX wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/components/base/buttons/button-utility.tsx Prettier formatting (imports, typing, JSX wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/components/base/avatar/utils.ts Prettier formatting (quotes, spacing)
openmetadata-ui-core-components/src/main/resources/ui/src/components/base/avatar/base-components/index.tsx Prettier formatting (quote style)
openmetadata-ui-core-components/src/main/resources/ui/src/components/base/avatar/base-components/avatar-online-indicator.tsx Prettier formatting (quotes, wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/components/base/avatar/base-components/avatar-company-icon.tsx Prettier formatting (quotes, JSX ordering)
openmetadata-ui-core-components/src/main/resources/ui/src/components/base/avatar/base-components/avatar-add-button.tsx Prettier formatting (imports, JSX wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/components/base/avatar/avatar-label-group.tsx Prettier formatting (quotes, wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/components/base/alert/alert.tsx Prettier formatting (imports, quotes, prop ordering)
openmetadata-ui-core-components/src/main/resources/ui/src/components/application/popover/popover.tsx Prettier formatting (imports, quotes, JSX ordering)
openmetadata-ui-core-components/src/main/resources/ui/src/components/application/pagination/pagination-line.tsx Prettier formatting (quotes, wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/components/application/pagination/pagination-dot.tsx Prettier formatting (quotes, wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/components/application/modals/modal.tsx Prettier formatting (imports, quotes, JSX ordering)
openmetadata-ui-core-components/src/main/resources/ui/src/components/application/date-picker/range-preset.tsx Prettier formatting (imports, wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/components/application/date-picker/date-picker.tsx Prettier formatting (imports, wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/components/application/date-picker/date-input.tsx Prettier formatting (imports, wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/components/application/date-picker/calendar.tsx Prettier formatting (imports, JSX wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/components/application/app-navigation/config.ts Prettier formatting (type wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/components/application/app-navigation/base-components/nav-list.tsx Prettier formatting (quotes, JSX ordering)
openmetadata-ui-core-components/src/main/resources/ui/src/components/application/app-navigation/base-components/nav-item-button.tsx Prettier formatting (quotes, JSX ordering)
openmetadata-ui-core-components/src/main/resources/ui/src/components/application/app-navigation/base-components/mobile-header.tsx Prettier formatting (quotes, JSX ordering)
openmetadata-ui-core-components/src/main/resources/ui/src/components/application/accordion/accordion.tsx Prettier formatting (quotes, wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/components/SnackbarContent.tsx Prettier formatting (long string wrapping)
openmetadata-ui-core-components/src/main/resources/ui/src/colors/generateMuiPalettes.ts Prettier formatting (imports, line wrapping)
openmetadata-ui-core-components/src/main/resources/ui/package.json Add lint/format scripts + devDependencies for ESLint/Prettier
openmetadata-ui-core-components/src/main/resources/ui/eslint.config.mjs New ESLint flat config for TS/React + Storybook overrides
openmetadata-ui-core-components/src/main/resources/ui/.prettierrc.yaml New Prettier configuration
openmetadata-ui-core-components/src/main/resources/ui/.prettierignore New Prettier ignore rules

Copilot AI review requested due to automatic review settings March 23, 2026 08:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 125 out of 146 changed files in this pull request and generated 4 comments.

Copilot AI review requested due to automatic review settings March 23, 2026 11:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 125 out of 147 changed files in this pull request and generated 4 comments.

Copilot AI review requested due to automatic review settings March 23, 2026 11:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 125 out of 147 changed files in this pull request and generated 1 comment.

Comment on lines 50 to 51
setCopied(id || true);
setTimeout(() => setCopied(false), DEFAULT_TIMEOUT);
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The timeout isn’t cleared on unmount and repeated calls can queue multiple timeouts, causing state updates after unmount or unexpected “copied” flicker. Consider storing the timeout id in a ref and clearing it before scheduling a new one, plus cleaning it up in an effect cleanup.

Copilot uses AI. Check for mistakes.
@gitar-bot
Copy link

gitar-bot bot commented Mar 23, 2026

Code Review ✅ Approved 5 resolved / 5 findings

Integrates Prettier and ESLint tooling for openmetadata-ui-core-components to enforce code quality standards. Resolves workflow trigger issues, removes debug logging, and corrects the CI configuration to properly lint only changed files with correct path handling.

✅ 5 resolved
Bug: Workflow trigger change breaks all CI jobs

📄 .github/workflows/ui-checkstyle.yml:15 📄 .github/workflows/ui-checkstyle.yml:48
Changing the trigger from pull_request_target to pull_request (line 15) breaks the authorize job, which still checks github.event_name == 'pull_request_target' (line 48). Since pull_request events will never satisfy this condition, the authorize job is always skipped. All downstream jobs (needs: authorize) — including the new core-components lint job — will therefore be skipped as well, completely disabling UI checkstyle CI.

This means no linting or formatting checks will actually run for any PR.

Bug: Debug console.log left in production component

📄 openmetadata-ui-core-components/src/main/resources/ui/src/components/base/progress-indicators/simple-circle.tsx:18
A test console.log('her test') statement was left in the CircleProgressBar component. This will log on every render in production, and also violates the 'no-console': 'error' ESLint rule configured in the new eslint.config.mjs. This appears to be from the 'Add console log for testing' commit (4edf723) that was never cleaned up.

Bug: Redundant path filter for core-components eslint config

📄 .github/workflows/ui-checkstyle.yml:28-29
Line 29 adds a specific filter for openmetadata-ui-core-components/src/main/resources/ui/eslint.config.mjs, but line 28 already covers it with the glob pattern openmetadata-ui-core-components/src/main/resources/ui/**. The specific path is redundant.

Performance: Core-components CI job lints all files instead of only changed ones

📄 .github/workflows/ui-checkstyle.yml:776-778
The new lint-core-components CI job runs yarn lint:fix and yarn pretty on the entire src/ directory, whereas the equivalent lint-src job for the main UI passes only $CHANGED_FILES to each command. For a small package this is acceptable today, but as the core-components package grows, this will make CI runs slower than necessary.

Consider aligning with the lint-src pattern: capture added_modified_files from the changed-files step into an env var, then pass those specific files to the lint and prettier commands.

Bug: Core-components CI lint uses wrong file paths

📄 .github/workflows/ui-checkstyle.yml:766-777
The lint-core-components job's changed-files step (line 766) does not set the path parameter, so tj-actions/changed-files returns paths relative to the repository root (e.g. openmetadata-ui-core-components/src/main/resources/ui/src/components/foo.tsx). However, the lint step (line 775) runs with working-directory: ${{ env.CORE_COMPONENTS_WORKING_DIRECTORY }} (i.e. openmetadata-ui-core-components/src/main/resources/ui), so yarn lint:base --fix $CHANGED_FILES will receive repo-root-relative paths that don't exist relative to the working directory.

Compare with the lint-src job (line 101-105) which correctly sets path: ${{ env.UI_WORKING_DIRECTORY }} so that returned file paths are relative to the working directory.

This means the lint check will silently pass (ESLint won't find the files) rather than actually linting changed code.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@github-actions
Copy link
Contributor

❌ Lint Check Failed — ESLint + Prettier (core-components)

The following files have style issues that need to be fixed:

Fix locally:

cd openmetadata-ui-core-components/src/main/resources/ui
yarn lint:fix && yarn pretty

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 125 out of 147 changed files in this pull request and generated 6 comments.

Comment on lines +18 to +19
console.log({ value, min, max, percentage });

Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

console.log was introduced in a non-story component. This will (1) fail linting with the new no-console: 'error' rule, and (2) emit noisy logs in production builds. Please remove the log statement (or gate it behind an explicit dev-only flag if you truly need it).

Suggested change
console.log({ value, min, max, percentage });

Copilot uses AI. Check for mistakes.
className,
progressClassName,
}: ProgressIndicatorWithTextProps) => {
const percentage = ((value - min) * 100) / (max - min);
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both ProgressBarBase and ProgressBar still divide by (max - min) without guarding against max <= min. This can produce Infinity/NaN, which then leaks into transform: translateX(...) and position styles (e.g., left: 'NaN%'). Suggest handling max - min <= 0 (similar to CircleProgressBar in simple-circle.tsx) and clamping the resulting percentage to [0, 100].

Copilot uses AI. Check for mistakes.

- uses: actions/setup-node@v4
with:
node-version-file: "${{ env.UI_WORKING_DIRECTORY }}/.nvmrc"
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core-components lint job uses the Node version from openmetadata-ui/.../.nvmrc rather than the core-components directory. If core-components expects a different Node version (or if the UI .nvmrc changes independently), this job may start failing unexpectedly. Prefer node-version-file: \"${{ env.CORE_COMPONENTS_WORKING_DIRECTORY }}/.nvmrc\" (and add one there) or hardcode a shared version explicitly.

Suggested change
node-version-file: "${{ env.UI_WORKING_DIRECTORY }}/.nvmrc"
node-version-file: "${{ env.CORE_COMPONENTS_WORKING_DIRECTORY }}/.nvmrc"

Copilot uses AI. Check for mistakes.
authorize:
if: |
github.event_name == 'pull_request_target' &&
github.event_name == 'pull_request' &&
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching from pull_request_target to pull_request improves security, but it also commonly removes pull-requests: write capabilities for PRs originating from forks (GitHub restricts the GITHUB_TOKEN to read-only in that case). The steps that create/update/delete PR comments can fail due to insufficient permissions. Consider gating PR-comment steps to same-repo PRs (e.g., if: github.event.pull_request.head.repo.full_name == github.repository), or splitting comments into a pull_request_target workflow that only reads artifacts/results and never checks out untrusted code.

Suggested change
github.event_name == 'pull_request' &&
github.event_name == 'pull_request' &&
github.event.pull_request.head.repo.full_name == github.repository &&

Copilot uses AI. Check for mistakes.
runs-on: ubuntu-latest
permissions:
contents: read
pull-requests: write
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching from pull_request_target to pull_request improves security, but it also commonly removes pull-requests: write capabilities for PRs originating from forks (GitHub restricts the GITHUB_TOKEN to read-only in that case). The steps that create/update/delete PR comments can fail due to insufficient permissions. Consider gating PR-comment steps to same-repo PRs (e.g., if: github.event.pull_request.head.repo.full_name == github.repository), or splitting comments into a pull_request_target workflow that only reads artifacts/results and never checks out untrusted code.

Copilot uses AI. Check for mistakes.
Comment on lines +811 to +812
- name: Post failure comment
if: failure()
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching from pull_request_target to pull_request improves security, but it also commonly removes pull-requests: write capabilities for PRs originating from forks (GitHub restricts the GITHUB_TOKEN to read-only in that case). The steps that create/update/delete PR comments can fail due to insufficient permissions. Consider gating PR-comment steps to same-repo PRs (e.g., if: github.event.pull_request.head.repo.full_name == github.repository), or splitting comments into a pull_request_target workflow that only reads artifacts/results and never checks out untrusted code.

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Contributor

🟡 Playwright Results — all passed (17 flaky)

✅ 3392 passed · ❌ 0 failed · 🟡 17 flaky · ⏭️ 183 skipped

Shard Passed Failed Flaky Skipped
🟡 Shard 1 452 0 3 2
✅ Shard 2 305 0 0 1
🟡 Shard 3 670 0 5 33
🟡 Shard 4 685 0 3 41
✅ Shard 5 672 0 0 73
🟡 Shard 6 608 0 6 33
🟡 17 flaky test(s) (passed on retry)
  • Flow/Tour.spec.ts › Tour should work from help section (shard 1, 1 retry)
  • Flow/Tour.spec.ts › Tour should work from welcome screen (shard 1, 1 retry)
  • Flow/Tour.spec.ts › Tour should work from URL directly (shard 1, 1 retry)
  • Features/BulkImport.spec.ts › Database (shard 3, 1 retry)
  • Features/DataQuality/TestCaseIncidentPermissions.spec.ts › User with TEST_CASE.EDIT_ALL can see edit icon on incidents (shard 3, 1 retry)
  • Features/DataQuality/TestCaseResultPermissions.spec.ts › User with only VIEW cannot PATCH results (shard 3, 1 retry)
  • Features/ImpactAnalysis.spec.ts › verify tier for Asset level impact analysis (shard 3, 1 retry)
  • Features/Permissions/GlossaryPermissions.spec.ts › Team-based permissions work correctly (shard 3, 1 retry)
  • Pages/Customproperties-part2.spec.ts › entityReferenceList shows item count, scrollable list, no expand toggle (shard 4, 1 retry)
  • Pages/DescriptionVisibility.spec.ts › Customized Table detail page Description widget shows long description (shard 4, 1 retry)
  • Pages/Domains.spec.ts › Multiple consecutive domain renames preserve all associations (shard 4, 1 retry)
  • Pages/Glossary.spec.ts › Async Delete - multiple deletes with mixed results (shard 6, 1 retry)
  • Pages/HyperlinkCustomProperty.spec.ts › should show No Data placeholder when hyperlink has no value (shard 6, 1 retry)
  • Pages/Lineage.spec.ts › Lineage creation from SearchIndex entity (shard 6, 1 retry)
  • Pages/ODCSImportExport.spec.ts › Multi-object ODCS contract - object selector shows all schema objects (shard 6, 1 retry)
  • Pages/Users.spec.ts › Permissions for table details page for Data Consumer (shard 6, 1 retry)
  • VersionPages/EntityVersionPages.spec.ts › Directory (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants