Migrated mui components with untitled-ui by Rohit0301 · Pull Request #26673 · open-metadata/OpenMetadata

Rohit0301 · 2026-03-22T07:11:56Z

Describe your changes:

Components migrated

useDataProductListingData.tsx
DomainTypeChip.tsx
CopyToClipboardButton.tsx
PropertyValue.tsx
LdapRoleMappingWidget.tsx
useDomainCardTemplates.tsx
useFilterSelection.tsx
usePageHeader.tsx
useTitleAndCount.tsx

Fixes 3273

I worked on ... because ...

Screen.Recording.2026-03-23.at.7.44.54.PM.mov

Type of change:

Checklist:

I have read the CONTRIBUTING document.
My PR title is Fixes <issue-number>: <short explanation>
I have commented on my code, particularly in hard-to-understand areas.
For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

github-actions · 2026-03-22T08:50:47Z

🔴 Playwright Results — 1 failure(s), 17 flaky

✅ 3112 passed · ❌ 1 failed · 🟡 17 flaky · ⏭️ 207 skipped

Shard	Passed	Failed	Flaky	Skipped
🔴 Shard 1	452	1	2	2
🟡 Shard 2	541	0	5	33
🟡 Shard 3	541	0	5	27
🟡 Shard 4	537	0	1	45
✅ Shard 5	511	0	0	67
🟡 Shard 6	530	0	4	33

Genuine Failures (failed on all attempts)

❌ Pages/SearchIndexApplication.spec.ts › Search Index Application (shard 1)

�[31mTest timeout of 180000ms exceeded.�[39m

🟡 17 flaky test(s) (passed on retry)

Features/CustomizeDetailPage.spec.ts › API Endpoint - customization should work (shard 1, 1 retry)
Flow/Tour.spec.ts › Tour should work from welcome screen (shard 1, 1 retry)
Features/BulkImport.spec.ts › Database (shard 2, 1 retry)
Features/DataQuality/TestCaseIncidentPermissions.spec.ts › User with TEST_CASE.EDIT_ALL can see edit icon on incidents (shard 2, 1 retry)
Features/DataQuality/TestCaseResultPermissions.spec.ts › User with only VIEW cannot PATCH results (shard 2, 1 retry)
Features/EntitySummaryPanel.spec.ts › should display summary panel for table (shard 2, 1 retry)
Features/EntitySummaryPanel.spec.ts › should display summary panel for tableColumn (shard 2, 1 retry)
Features/Permissions/GlossaryPermissions.spec.ts › Team-based permissions work correctly (shard 3, 1 retry)
Features/RestoreEntityInheritedFields.spec.ts › Validate restore with Inherited domain and data products assigned (shard 3, 1 retry)
Flow/PersonaDeletionUserProfile.spec.ts › User profile loads correctly before and after persona deletion (shard 3, 1 retry)
Flow/PersonaFlow.spec.ts › Set default persona for team should work properly (shard 3, 1 retry)
Pages/Customproperties-part2.spec.ts › entityReferenceList shows item count, scrollable list, no expand toggle (shard 3, 1 retry)
Pages/DomainAdvanced.spec.ts › Remove multiple assets from domain at once (shard 4, 1 retry)
Pages/HyperlinkCustomProperty.spec.ts › should display URL when no display text is provided (shard 6, 1 retry)
Pages/Lineage.spec.ts › Lineage creation from SearchIndex entity (shard 6, 1 retry)
Pages/ServiceEntity.spec.ts › Update displayName (shard 6, 1 retry)
Pages/Users.spec.ts › Permissions for table details page for Data Consumer (shard 6, 1 retry)

📦 Download artifacts

How to debug locally

# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

github-actions · 2026-03-23T11:06:58Z

Jest test Coverage

UI tests summary

Lines	Statements	Branches	Functions
	65.02% (58083/89327)	44.82% (30715/68517)	47.82% (9197/19232)

...ta-ui/src/main/resources/ui/src/components/common/atoms/domain/ui/useDomainCardTemplates.tsx

Co-authored-by: Rohit0301 <Rohit0301@users.noreply.github.com>

…adata/OpenMetadata into untitled-ui-migration-3

ShaileshParmar11 · 2026-03-24T07:29:24Z

...ta-ui/src/main/resources/ui/src/components/common/atoms/domain/ui/useDomainCardTemplates.tsx

+const getGlossaryTags = (entity: Domain | DataProduct): TagLabel[] =>
+  entity.tags?.filter((tag) => tag.source === 'Glossary') ?? [];
+
+const getClassificationTags = (entity: Domain | DataProduct): TagLabel[] =>
+  entity.tags?.filter((tag) => tag.source === 'Classification') ?? [];
+


we might already have this util fn, and if not, lets move this to utils file.

ShaileshParmar11 · 2026-03-24T07:32:18Z

...metadata-ui/src/main/resources/ui/src/components/common/atoms/filters/useFilterSelection.tsx

+                    title={filter.values.join(', ')}
+                    weight="medium">
+                    {filter.values.join(', ')}


unnecessary 2 loops

ShaileshParmar11 · 2026-03-24T07:33:42Z

openmetadata-ui/src/main/resources/ui/src/components/common/atoms/navigation/usePageHeader.tsx

-              </Typography>
+      <Card className="tw:mb-5 tw:p-5">
+        <div className="tw:flex tw:items-center tw:justify-between">
+          <div>


please check if we need this blank div?

required, it wraps 2 elements

gitar-bot · 2026-03-24T17:44:22Z

Code Review ✅ Approved 1 resolved / 1 findings

Migrated MUI components to untitled-ui with fixes for domain icon display and test compatibility. No issues found.

✅ 1 resolved

✅ Bug: Domain card template missing overflow protection classes

📄 openmetadata-ui/src/main/resources/ui/src/components/common/atoms/domain/ui/useDomainCardTemplates.tsx:79 📄 openmetadata-ui/src/main/resources/ui/src/components/common/atoms/domain/ui/useDomainCardTemplates.tsx:91 📄 openmetadata-ui/src/main/resources/ui/src/components/common/atoms/domain/ui/useDomainCardTemplates.tsx:107 📄 openmetadata-ui/src/main/resources/ui/src/components/common/atoms/domain/ui/useDomainCardTemplates.tsx:120 📄 openmetadata-ui/src/main/resources/ui/src/components/common/atoms/domain/ui/useDomainCardTemplates.tsx:160 📄 openmetadata-ui/src/main/resources/ui/src/components/common/atoms/domain/ui/useDomainCardTemplates.tsx:172 📄 openmetadata-ui/src/main/resources/ui/src/components/common/atoms/domain/ui/useDomainCardTemplates.tsx:187 📄 openmetadata-ui/src/main/resources/ui/src/components/common/atoms/domain/ui/useDomainCardTemplates.tsx:200
The domain card template's Grid.Item elements (lines 79, 91, 107, 120) are missing the tw:min-w-0 tw:overflow-hidden classes that the data product card template correctly includes (lines 160, 172, 187, 200). The old MUI code had minWidth: 0, overflow: 'hidden' on all Box elements in both templates. Without these classes, long owner names, tags, or glossary terms could overflow the grid cell and break the card layout.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

`Auto-apply`	`Compact`
`gitar auto-apply:on`	`gitar display:verbose`

_{Was this helpful? React with 👍 / 👎 | Gitar}

sonarqubecloud · 2026-03-24T18:10:44Z

Quality Gate passed for 'open-metadata-ui'

Issues
7 New issues
0 Accepted issues

Measures
1 Security Hotspot
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Migrated mui components with untitled-ui

0f433b1

Rohit0301 self-assigned this Mar 22, 2026

Rohit0301 added the safe to test Add this label to run secure Github workflows on PRs label Mar 22, 2026

Rohit0301 requested a review from a team as a code owner March 22, 2026 07:11

Rohit0301 temporarily deployed to test March 22, 2026 07:22 — with GitHub Actions Inactive

Rohit0301 had a problem deploying to test March 22, 2026 07:22 — with GitHub Actions Failure

Rohit0301 temporarily deployed to test March 22, 2026 07:22 — with GitHub Actions Inactive

Rohit0301 had a problem deploying to test March 22, 2026 07:22 — with GitHub Actions Failure

Rohit0301 temporarily deployed to test March 22, 2026 07:22 — with GitHub Actions Inactive

Rohit0301 and others added 2 commits March 23, 2026 16:09

fixed playwright and unit tests

954a2c5

Merge branch 'main' into untitled-ui-migration-3

b4da2cc

Rohit0301 temporarily deployed to test March 23, 2026 10:50 — with GitHub Actions Inactive

Rohit0301 had a problem deploying to test March 23, 2026 10:50 — with GitHub Actions Failure

Rohit0301 temporarily deployed to test March 23, 2026 10:50 — with GitHub Actions Inactive

fixed playwright test

db088ff

gitar-bot bot reviewed Mar 23, 2026

View reviewed changes

...ta-ui/src/main/resources/ui/src/components/common/atoms/domain/ui/useDomainCardTemplates.tsx Show resolved Hide resolved

Rohit0301 temporarily deployed to test March 23, 2026 12:44 — with GitHub Actions Inactive

fixed the domain icon issue

0fba88a

Rohit0301 requested a review from chirag-madlani as a code owner March 23, 2026 14:22

Rohit0301 requested a review from karanh37 as a code owner March 23, 2026 14:22

Rohit0301 and others added 3 commits March 23, 2026 19:53

Merge branch 'main' into untitled-ui-migration-3

0c6bb4b

Merge branch 'main' into untitled-ui-migration-3

ab44cf5

Co-authored-by: Rohit0301 <Rohit0301@users.noreply.github.com>

Merge branch 'untitled-ui-migration-3' of https://github.com/open-met…

92930c7

…adata/OpenMetadata into untitled-ui-migration-3

gitar-bot bot temporarily deployed to test March 23, 2026 14:39 Inactive

ShaileshParmar11 reviewed Mar 24, 2026

View reviewed changes

addressed PR comments

6f3f192

Rohit0301 had a problem deploying to test March 24, 2026 17:50 — with GitHub Actions Failure

Rohit0301 temporarily deployed to test March 24, 2026 17:50 — with GitHub Actions Inactive

ShaileshParmar11 approved these changes Mar 24, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrated mui components with untitled-ui#26673

Migrated mui components with untitled-ui#26673
Rohit0301 wants to merge 9 commits intomainfrom
untitled-ui-migration-3

Rohit0301 commented Mar 22, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 22, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 23, 2026 •

edited

Loading

Uh oh!

Uh oh!

ShaileshParmar11 Mar 24, 2026

Uh oh!

Rohit0301 Mar 24, 2026

Uh oh!

ShaileshParmar11 Mar 24, 2026

Uh oh!

Rohit0301 Mar 24, 2026

Uh oh!

ShaileshParmar11 Mar 24, 2026

Uh oh!

Rohit0301 Mar 24, 2026

Uh oh!

gitar-bot bot commented Mar 24, 2026 •

edited

Loading

Uh oh!

sonarqubecloud bot commented Mar 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Rohit0301 commented Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your changes:

Type of change:

Checklist:

Uh oh!

github-actions bot commented Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔴 Playwright Results — 1 failure(s), 17 flaky

Genuine Failures (failed on all attempts)

Uh oh!

github-actions bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Jest test Coverage

UI tests summary

Uh oh!

Uh oh!

ShaileshParmar11 Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Rohit0301 Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

ShaileshParmar11 Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Rohit0301 Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

ShaileshParmar11 Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Rohit0301 Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

gitar-bot bot commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud bot commented Mar 24, 2026

Quality Gate passed for 'open-metadata-ui'

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Rohit0301 commented Mar 22, 2026 •

edited

Loading

github-actions bot commented Mar 22, 2026 •

edited

Loading

github-actions bot commented Mar 23, 2026 •

edited

Loading

gitar-bot bot commented Mar 24, 2026 •

edited

Loading