Migration: replace mui theme colors with tailwind theme colors#26671
Migration: replace mui theme colors with tailwind theme colors#26671
Conversation
openmetadata-ui/src/main/resources/ui/src/utils/EdgeStyleUtils.test.ts
Outdated
Show resolved
Hide resolved
🟡 Playwright Results — all passed (17 flaky)✅ 3416 passed · ❌ 0 failed · 🟡 17 flaky · ⏭️ 183 skipped
🟡 17 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
| const EDGE_COLOR_BRAND = 'var(--tw-color-brand-600)'; | ||
| const EDGE_COLOR_INDIGO = 'var(--tw-color-indigo-600)'; | ||
| const EDGE_COLOR_ERROR = 'var(--tw-color-error-600)'; | ||
| const EDGE_COLOR_DEFAULT = 'rgba(177, 177, 183)'; |
There was a problem hiding this comment.
💡 Bug: rgba() used with 3 args instead of rgb()
The constant EDGE_COLOR_DEFAULT = 'rgba(177, 177, 183)' uses rgba() with only 3 arguments. The rgba() function expects 4 arguments (r, g, b, alpha). While most modern browsers tolerate this, it's technically invalid CSS and should be rgb(177, 177, 183). This is a pre-existing issue carried over from the old inline value, but since you're extracting it into a named constant, it's a good opportunity to fix it.
Suggested fix:
const EDGE_COLOR_DEFAULT = 'rgb(177, 177, 183)';
Was this helpful? React with 👍 / 👎 | Reply gitar fix to apply this suggestion
Code Review 👍 Approved with suggestions 1 resolved / 2 findingsMigrates MUI theme colors to Tailwind theme colors, with test CSS variable naming now correctly aligned to source constants. Consider using rgb() instead of rgba() for the EDGE_COLOR_DEFAULT constant since it doesn't specify an alpha channel. 💡 Bug: rgba() used with 3 args instead of rgb()📄 openmetadata-ui/src/main/resources/ui/src/utils/EdgeStyleUtils.ts:18 The constant Suggested fix✅ 1 resolved✅ Bug: Test CSS variable names don't match source constants
🤖 Prompt for agentsOptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|



Describe your changes:
Fixes 3275
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>