Skip to content

Fix Failing Test AwsCredentialsUtilTest#25745

Merged
mohityadav766 merged 1 commit intomainfrom
fix-failing-test
Feb 7, 2026
Merged

Fix Failing Test AwsCredentialsUtilTest#25745
mohityadav766 merged 1 commit intomainfrom
fix-failing-test

Conversation

@mohityadav766
Copy link
Member

@mohityadav766 mohityadav766 commented Feb 7, 2026

Describe your changes:

  • Fix Failing Test for AwsCredentialsUtilTest

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

  • Fixed test configuration:
    • Added config.setEnabled(true) to three tests in AwsCredentialsUtilTest.java that expect default AWS credential provider
  • New validation test:
    • testBuildCredentialsProviderThrowsWhenNotConfigured() verifies IllegalArgumentException when AWS credentials are not configured

This will update automatically on new commits.


@mohityadav766 mohityadav766 self-assigned this Feb 7, 2026
@mohityadav766 mohityadav766 requested a review from a team as a code owner February 7, 2026 13:52
@github-actions github-actions bot added backend safe to test Add this label to run secure Github workflows on PRs labels Feb 7, 2026
@mohityadav766 mohityadav766 merged commit b40e949 into main Feb 7, 2026
16 of 24 checks passed
@mohityadav766 mohityadav766 deleted the fix-failing-test branch February 7, 2026 13:52
@gitar-bot
Copy link

gitar-bot bot commented Feb 7, 2026

Code Review ✅ Approved

Clean test fix that correctly aligns three existing tests with the implementation's enabled=true requirement for the default credential provider chain, and adds a new test for the exception path. No issues found.

Rules 🎸 1 action taken

Gitar Rules

🎸 Summary Enhancement: Appended Summary by Gitar section with 2 technical bullet points to PR description

2 rules not applicable. Show all rules by commenting gitar display:verbose.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant