-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[WIP]: Improve UI build time #25699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
[WIP]: Improve UI build time #25699
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 changes: 71 additions & 0 deletions
71
openmetadata-ui/src/main/resources/ui/vite-plugin-svgr-optimized.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| /* | ||
| * Copyright 2025 Collate. | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import fs from 'fs'; | ||
| import { transform as svgrTransform } from '@svgr/core'; | ||
| import jsxPlugin from '@svgr/plugin-jsx'; | ||
| import { Plugin, transformWithEsbuild } from 'vite'; | ||
|
|
||
| export default function viteSvgrOptimized(): Plugin { | ||
| return { | ||
| name: 'vite-plugin-svgr-optimized', | ||
| enforce: 'pre', | ||
|
|
||
| async transform(code, id) { | ||
| // Early exit for non-SVG files | ||
| if (!id.endsWith('.svg')) { | ||
| return null; | ||
| } | ||
|
|
||
| if (id.includes('node_modules')) { | ||
| return null; | ||
| } | ||
|
|
||
| const cleanId = id.replace(/[?#].*$/s, ''); | ||
|
|
||
| try { | ||
| const svgCode = await fs.promises.readFile(cleanId, 'utf8'); | ||
|
|
||
| const componentCode = await svgrTransform( | ||
| svgCode, | ||
| { | ||
| ref: true, | ||
| exportType: 'named', | ||
| svgo: true, | ||
| titleProp: true, | ||
| plugins: ['@svgr/plugin-jsx'], | ||
| }, | ||
| { | ||
| filePath: cleanId, | ||
| caller: { | ||
| previousExport: code, | ||
| defaultPlugins: [jsxPlugin], | ||
| }, | ||
| } | ||
| ); | ||
|
|
||
| const res = await transformWithEsbuild(componentCode, id, { | ||
| loader: 'jsx', | ||
| jsx: 'automatic', | ||
| }); | ||
|
|
||
| return { | ||
| code: res.code, | ||
| map: res.map, | ||
| }; | ||
| } catch (error) { | ||
| this.error(`Failed to transform SVG: ${id}\n${error}`); | ||
| } | ||
| }, | ||
| }; | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 **Bug:** Missing `lazy` and `Suspense` imports in TableUtils.tsx
The file uses
lazy()to importKnowledgeGraphat line 206 and wraps it with<Suspense>at line 1004, but the diff doesn't show the necessary React imports being added.Looking at other files in this PR (EntityLineageTab.tsx, PlatformLineage.tsx, SwaggerPage/index.tsx), they all properly add
lazyandSuspenseto their React imports. However, TableUtils.tsx is missing this change.Impact: This will cause a build/runtime error as
lazyandSuspenseare undefined.Suggested fix: Add
lazyandSuspenseto the React imports at the top of TableUtils.tsx:Or if React is already imported:
Was this helpful? React with 👍 / 👎