Skip to content

Flaky(UI): Glossary import export #25693

Merged
dhruvjsx merged 4 commits intoopen-metadata:mainfrom
dhruvjsx:fix-bulk-edit
Feb 6, 2026
Merged

Flaky(UI): Glossary import export #25693
dhruvjsx merged 4 commits intoopen-metadata:mainfrom
dhruvjsx:fix-bulk-edit

Conversation

@dhruvjsx
Copy link
Contributor

@dhruvjsx dhruvjsx commented Feb 4, 2026

Describe your changes:

Screenshot 2026-02-04 at 2 38 37 PM

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

  • Fixed flaky file upload:
    • Replaced getByTestId('upload-file-widget') with reliable [type="file"] selector
  • Improved wait strategy:
    • Replaced arbitrary waitForTimeout(500) with state-based waits for upload widget to disappear
  • Streamlined assertions:
    • Removed explicit timeout parameters, relying on Playwright's default wait behavior for better test stability

This will update automatically on new commits.


@dhruvjsx dhruvjsx requested a review from a team as a code owner February 4, 2026 09:14
@dhruvjsx dhruvjsx added safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch labels Feb 4, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
65.84% (56032/85108) 45.18% (29334/64923) 47.95% (8848/18454)

@gitar-bot
Copy link

gitar-bot bot commented Feb 6, 2026

Code Review 👍 Approved with suggestions 0 resolved / 1 findings

Clean fix for flaky tests — replaces arbitrary timeouts with state-based waits and uses a more reliable file input selector. One minor suggestion to scope the [type="file"] selector for future robustness.

💡 Quality: Generic [type="file"] selector could match multiple inputs

📄 openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/GlossaryImportExport.spec.ts:160

The selector [type="file"] is used across all 6 occurrences to target the file input. If the page ever introduces a second <input type="file">, this selector would match multiple elements, potentially causing test failures or operating on the wrong element.

Consider using a more specific selector that scopes to the upload widget, e.g.:

await page.waitForSelector('[data-testid="upload-file-widget"] [type="file"]', { state: 'attached' });
await page.setInputFiles('[data-testid="upload-file-widget"] [type="file"]', ...);

This combines the reliability of [type="file"] (which avoids issues with the test-id not being directly on the input) with the specificity of the upload widget container. That said, if there's only ever one file input on this page, the current approach works fine — this is just a robustness suggestion.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2026

@dhruvjsx dhruvjsx merged commit 9f094f4 into open-metadata:main Feb 6, 2026
18 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

Failed to cherry-pick changes to the 1.11.9 branch.
Please cherry-pick the changes manually.
You can find more details here.

dhruvjsx added a commit that referenced this pull request Feb 6, 2026
* fixed glossary import export flakyness

* removed timeout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants