fix(flagd-provider): update fractional targeting test expectations for flagd v0.15.4#166
Open
jonathannorris wants to merge 2 commits into
Open
fix(flagd-provider): update fractional targeting test expectations for flagd v0.15.4#166jonathannorris wants to merge 2 commits into
jonathannorris wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the expected hex color values in the flagd provider's test suite for fractional targeting. Feedback suggests that the updated expectations are less effective because most keys now resolve to the default variant, making it difficult to verify if the fractional logic is functioning correctly or simply falling back to defaults. It is recommended to use targeting keys that map to a more diverse set of variants to ensure proper test coverage.
…r flagd v0.15.4 The fractional evaluator bucketing algorithm changed in flagd v0.15.4 (high-precision integer math replacing float-based bucketing), causing all color-palette-experiment assignments to shift. Updated expected values verified against the twmb/murmur3 + distributeValue logic used by flagd v0.15.4. Closes #73 Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
…al test Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
980a417 to
50386f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
color-palette-experimentfractional targeting test expectations to match the bucketing behavior in flagdv0.15.4(hash * totalWeight) >> 32), which rebucketed all users — tracked in [flagd] [FEATURE] Harden Hashing Consistency And Add Support For Non-string Attributes in Fractional Evaluation #73twmb/murmur3+distributeValuealgorithm from flagd's source atcore/v0.15.4