Skip to content

fix(flagd-provider): update fractional targeting test expectations for flagd v0.15.4#166

Open
jonathannorris wants to merge 2 commits into
mainfrom
fix/flagd-fractional-test-expectations
Open

fix(flagd-provider): update fractional targeting test expectations for flagd v0.15.4#166
jonathannorris wants to merge 2 commits into
mainfrom
fix/flagd-fractional-test-expectations

Conversation

@jonathannorris
Copy link
Copy Markdown
Member

@jonathannorris jonathannorris commented Apr 28, 2026

Summary

@jonathannorris jonathannorris requested a review from a team as a code owner April 28, 2026 20:53
@jonathannorris jonathannorris requested review from a team and beeme1mr April 28, 2026 20:54
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the expected hex color values in the flagd provider's test suite for fractional targeting. Feedback suggests that the updated expectations are less effective because most keys now resolve to the default variant, making it difficult to verify if the fractional logic is functioning correctly or simply falling back to defaults. It is recommended to use targeting keys that map to a more diverse set of variants to ensure proper test coverage.

Comment thread providers/openfeature-flagd-provider/spec/openfeature/flagd/provider_spec.rb Outdated
…r flagd v0.15.4

The fractional evaluator bucketing algorithm changed in flagd v0.15.4
(high-precision integer math replacing float-based bucketing), causing
all color-palette-experiment assignments to shift. Updated expected
values verified against the twmb/murmur3 + distributeValue logic used
by flagd v0.15.4.

Closes #73

Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
…al test

Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
@jonathannorris jonathannorris force-pushed the fix/flagd-fractional-test-expectations branch from 980a417 to 50386f8 Compare May 4, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants