Skip to content

chore: resolve open dependabot security alerts#389

Draft
jonathannorris wants to merge 1 commit intomainfrom
chore/dependabot-alerts
Draft

chore: resolve open dependabot security alerts#389
jonathannorris wants to merge 1 commit intomainfrom
chore/dependabot-alerts

Conversation

@jonathannorris
Copy link
Copy Markdown
Member

Summary

  • Bumped mako to >=1.3.12 via a constraint-dependencies entry in the root pyproject.toml to resolve CVE-2026-44307 (high severity, path traversal via backslash URI on Windows in TemplateLookup)
  • Regenerated uv.lock with mako 1.3.11 -> 1.3.12

Fixes Dependabot alert #30.

Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
@jonathannorris jonathannorris requested review from a team as code owners May 8, 2026 17:58
@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.20%. Comparing base (4ef1019) to head (c5b9b4a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #389      +/-   ##
==========================================
+ Coverage   90.16%   96.20%   +6.04%     
==========================================
  Files           1       47      +46     
  Lines         122     1741    +1619     
==========================================
+ Hits          110     1675    +1565     
- Misses         12       66      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the mako dependency to version 1.3.12 in pyproject.toml and uv.lock to address a security vulnerability. Feedback indicates that several unrelated version bumps for openfeature packages were included in the lockfile, which violates the project's policy against manual version updates and introduces unnecessary risk to a security-focused change.

Comment thread uv.lock
[[package]]
name = "openfeature-flagd-api"
version = "0.1.0"
version = "1.0.0"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This version bump for openfeature-flagd-api (0.1.0 -> 1.0.0) appears unrelated to the mako security fix. Including major version changes in a security chore PR is risky and out of scope. Please ensure the lockfile only contains the intended mako update and any strictly necessary transitive updates.

version = "0.1.0"
References
  1. Do not manually update the version in pyproject.toml or the changelog, as this is handled automatically.

Comment thread uv.lock
[[package]]
name = "openfeature-flagd-core"
version = "0.1.0"
version = "1.0.0"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This version bump for openfeature-flagd-core (0.1.0 -> 1.0.0) appears unrelated to the mako security fix. Including major version changes in a security chore PR is risky and out of scope.

version = "0.1.0"
References
  1. Do not manually update the version in pyproject.toml or the changelog, as this is handled automatically.

Comment thread uv.lock
[[package]]
name = "openfeature-provider-flagd"
version = "0.4.0"
version = "0.4.1"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This version bump for openfeature-provider-flagd (0.4.0 -> 0.4.1) appears unrelated to the mako security fix.

version = "0.4.0"
References
  1. Do not manually update the version in pyproject.toml or the changelog, as this is handled automatically.

Comment thread uv.lock
[[package]]
name = "openfeature-provider-ofrep"
version = "0.2.0"
version = "0.3.0"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This version bump for openfeature-provider-ofrep (0.2.0 -> 0.3.0) appears unrelated to the mako security fix.

version = "0.2.0"
References
  1. Do not manually update the version in pyproject.toml or the changelog, as this is handled automatically.

Comment thread pyproject.toml
[tool.uv]
required-version = ">=0.10.0"
package = false
constraint-dependencies = [
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not needed, a normal uv sync update should be enough. There is also a specialized command to only update a single package

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, good call — we shouldn't be adding constraint-dependencies here. will update to use uv lock --upgrade-package mako instead and drop that pyproject.toml change.

@jonathannorris jonathannorris marked this pull request as draft May 8, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants