Skip to content

Conversation

@petertriho
Copy link

@petertriho petertriho commented Jan 31, 2026

Resolves dependency conflicts between types-requests and boto3/moto on Python 3.9 for #331

This PR

  • Changes the types-requests dev dependency for both flipt and ofrep providers from types-requests>=2.32.0,<3.0.0 to types-requests>=2.31.0,<3.0.0

Related Issues

Fixes uv sync issues in #331

Notes

Follow-up Tasks

How to test

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @petertriho, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses uv synchronization issues by adjusting the version constraint for the types-requests development dependency across multiple OpenFeature providers. This change ensures compatibility and resolves build problems, particularly for a related pull request, by allowing a broader range of the types-requests package.

Highlights

  • Dependency Constraint Relaxation: The types-requests development dependency has been relaxed for both the openfeature-provider-flipt and openfeature-provider-ofrep providers, changing the version constraint from >=2.32.0,<3.0.0 to >=2.31.0,<3.0.0.
  • Version Bumps: The versions of openfeature-provider-flipt, openfeature-provider-ofrep, and openfeature-provider-unleash have been incremented in their respective pyproject.toml files and the uv.lock file.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly relaxes the version constraint for the types-requests development dependency in the flipt and ofrep providers, and bumps their respective versions. The changes are sound, but the changelogs for the updated providers have not been updated to reflect these new versions. I've added comments to address this.

[project]
name = "openfeature-provider-flipt"
version = "0.1.3"
version = "0.1.4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The package version has been bumped to 0.1.4, but the corresponding entry is missing in providers/openfeature-provider-flipt/CHANGELOG.md. Please add a changelog entry for this new version to keep the project's release history up to date.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the changelogs are generated automatically, not required?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. No need to bump this manually.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I removed the version bumps

@petertriho petertriho marked this pull request as draft January 31, 2026 00:54
@petertriho petertriho marked this pull request as ready for review January 31, 2026 01:00
"pytest>=8.4.0,<9.0.0",
"requests-mock>=1.12.0,<2.0.0",
"types-requests>=2.32.0,<3.0.0",
"types-requests>=2.31.0,<3.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a one-line comment with a brief explanation—just enough for the next person to understand that there’s a deliberate reason this constraint is written this way?

Copy link
Author

@petertriho petertriho Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, I also made it only affect python 3.9 sorry for the flip flopping. I changed it back to this (instead of splitting it between <3.10 and >=3.10 because I realise it just overcomplicating things and also would break existing installs on 3.9)

@petertriho petertriho changed the title chore: relax types-requests version constraint fix: resolve types-requests version conflicts Jan 31, 2026
@petertriho petertriho force-pushed the chore/type-requests branch 4 times, most recently from 66b1404 to 8570213 Compare January 31, 2026 02:00
@petertriho petertriho changed the title fix: resolve types-requests version conflicts fix: resolve types-requests dependency conflicts Jan 31, 2026
@petertriho petertriho force-pushed the chore/type-requests branch 2 times, most recently from 0f40219 to 5580c99 Compare January 31, 2026 02:02
@petertriho petertriho marked this pull request as draft January 31, 2026 02:12
@petertriho petertriho changed the title fix: resolve types-requests dependency conflicts chore: relax `types-requests version constraint Jan 31, 2026
@petertriho petertriho changed the title chore: relax `types-requests version constraint chore: relax types-requests version constraint Jan 31, 2026
@petertriho petertriho marked this pull request as ready for review January 31, 2026 02:19
@federicobond
Copy link
Member

Does this only happen on Python 3.9?

@petertriho
Copy link
Author

petertriho commented Jan 31, 2026

Does this only happen on Python 3.9?

Yes. I could change the deps to if that's preferred?

"types-requests>=2.31.0,<3.0.0; python_version<'3.10'",
"types-requests>=2.32.0,<3.0.0; python_version>='3.10'",

@codecov
Copy link

codecov bot commented Jan 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.52%. Comparing base (b9c164a) to head (24d14f7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #334   +/-   ##
=======================================
  Coverage   95.52%   95.52%           
=======================================
  Files          25       25           
  Lines        1252     1252           
=======================================
  Hits         1196     1196           
  Misses         56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petertriho the DCO is failing, probably you forgot to sign off your commit

Resolves dependency conflict between `types-requests` and `boto3`/`moto` on Python 3.9 for open-feature#331

Signed-off-by: Peter Tri Ho <mail@petertriho.com>
@petertriho
Copy link
Author

@gruebel thanks, forgot about that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants