-
Notifications
You must be signed in to change notification settings - Fork 26
chore: relax types-requests version constraint
#334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @petertriho, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly relaxes the version constraint for the types-requests development dependency in the flipt and ofrep providers, and bumps their respective versions. The changes are sound, but the changelogs for the updated providers have not been updated to reflect these new versions. I've added comments to address this.
| [project] | ||
| name = "openfeature-provider-flipt" | ||
| version = "0.1.3" | ||
| version = "0.1.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the changelogs are generated automatically, not required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. No need to bump this manually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I removed the version bumps
| "pytest>=8.4.0,<9.0.0", | ||
| "requests-mock>=1.12.0,<2.0.0", | ||
| "types-requests>=2.32.0,<3.0.0", | ||
| "types-requests>=2.31.0,<3.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a one-line comment with a brief explanation—just enough for the next person to understand that there’s a deliberate reason this constraint is written this way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, I also made it only affect python 3.9 sorry for the flip flopping. I changed it back to this (instead of splitting it between <3.10 and >=3.10 because I realise it just overcomplicating things and also would break existing installs on 3.9)
1b83cb5 to
20328df
Compare
types-requests version constrainttypes-requests version conflicts
66b1404 to
8570213
Compare
types-requests version conflictstypes-requests dependency conflicts
0f40219 to
5580c99
Compare
5580c99 to
f91388c
Compare
types-requests dependency conflictstypes-requests version constraint
|
Does this only happen on Python 3.9? |
Yes. I could change the deps to if that's preferred? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #334 +/- ##
=======================================
Coverage 95.52% 95.52%
=======================================
Files 25 25
Lines 1252 1252
=======================================
Hits 1196 1196
Misses 56 56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gruebel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@petertriho the DCO is failing, probably you forgot to sign off your commit
f91388c to
23bc7ff
Compare
Resolves dependency conflict between `types-requests` and `boto3`/`moto` on Python 3.9 for open-feature#331 Signed-off-by: Peter Tri Ho <mail@petertriho.com>
23bc7ff to
24d14f7
Compare
|
@gruebel thanks, forgot about that |
Resolves dependency conflicts between
types-requestsandboto3/motoon Python 3.9 for #331This PR
types-requestsdev dependency for bothfliptandofrepproviders fromtypes-requests>=2.32.0,<3.0.0totypes-requests>=2.31.0,<3.0.0Related Issues
Fixes uv sync issues in #331
Notes
Follow-up Tasks
How to test