docs(ADR): backfill context enrichment ADR in flagd#1850
Conversation
Signed-off-by: Konvalinka <lea.konvalinka@dynatrace.com>
Summary of ChangesHello @leakonvalinka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Architectural Decision Record (ADR) to Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
✅ Deploy Preview for polite-licorice-3db33c ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Code Review
This pull request adds a new Architecture Decision Record (ADR) for static and dynamic context enrichment in flagd. The ADR is well-written and accurately reflects the functionality. I've suggested a minor formatting improvement to ensure the document renders correctly and is easy to read.
Signed-off-by: Konvalinka <lea.konvalinka@dynatrace.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
left a comment
There was a problem hiding this comment.
Approved with some tweaks. This is historical so I will merge it next week unless somebody objects.
|



This PR
Related Issues
Closes #1745
Notes
If I missed anything, please point it out so I can add it!