Skip to content

docs(ADR): backfill context enrichment ADR in flagd#1850

Merged
toddbaert merged 4 commits intoopen-feature:mainfrom
open-feature-forking:doc/backfill-context-enrichment-adr
Jan 30, 2026
Merged

docs(ADR): backfill context enrichment ADR in flagd#1850
toddbaert merged 4 commits intoopen-feature:mainfrom
open-feature-forking:doc/backfill-context-enrichment-adr

Conversation

@leakonvalinka
Copy link
Copy Markdown
Member

This PR

  • backfills the ADR on static and dynamic context enrichment

Related Issues

Closes #1745

Notes

If I missed anything, please point it out so I can add it!

Signed-off-by: Konvalinka <lea.konvalinka@dynatrace.com>
@leakonvalinka leakonvalinka requested review from a team as code owners January 23, 2026 10:31
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 23, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @leakonvalinka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new Architectural Decision Record (ADR) to flagd, formally documenting the implementation and usage of static and dynamic context enrichment. The ADR clarifies how context data can be supplied to flagd for flag evaluations, either as persistent values configured at startup or as transient data extracted from incoming request headers. It also establishes a definitive merge priority for these context sources, ensuring predictable behavior when context keys overlap.

Highlights

  • New ADR Document: Introduces a new Architectural Decision Record (ADR) to formally document the existing static and dynamic context enrichment features in flagd.
  • Static Context Enrichment: Details the --context-value (-X) option, allowing static key-value pairs to be provided at startup for consistent context across all evaluations.
  • Dynamic Context Enrichment: Explains the --context-from-header (-H) option, enabling automatic extraction of context values from specific request headers for dynamic, per-request evaluations.
  • Context Merge Priority: Defines a clear priority list for merging context values when the same key is present in multiple sources (dynamic headers > static options > request body).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 23, 2026

Deploy Preview for polite-licorice-3db33c ready!

Name Link
🔨 Latest commit 2ffc31e
🔍 Latest deploy log https://app.netlify.com/projects/polite-licorice-3db33c/deploys/697bb8fcce055c0007641a81
😎 Deploy Preview https://deploy-preview-1850--polite-licorice-3db33c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new Architecture Decision Record (ADR) for static and dynamic context enrichment in flagd. The ADR is well-written and accurately reflects the functionality. I've suggested a minor formatting improvement to ensure the document renders correctly and is easy to read.

Comment thread docs/architecture-decisions/static-and-dynamic-context.md Outdated
leakonvalinka and others added 3 commits January 23, 2026 11:49
Signed-off-by: Konvalinka <lea.konvalinka@dynatrace.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Copy link
Copy Markdown
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some tweaks. This is historical so I will merge it next week unless somebody objects.

@sonarqubecloud
Copy link
Copy Markdown

@toddbaert toddbaert merged commit 48c53bc into open-feature:main Jan 30, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CHORE] Backfill ADR for static context and dynamic context enrichment

2 participants