Skip to content

Info screen accessibility improvements #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martenrebane wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Info screen accessibility improvements #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion app/src/main/kotlin/ee/ria/DigiDoc/ui/component/shared/HrefDynamicText.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ import androidx.compose.ui.platform.LocalDensity
import androidx.compose.ui.platform.LocalUriHandler
import androidx.compose.ui.platform.LocalWindowInfo
import androidx.compose.ui.platform.testTag
import androidx.compose.ui.semantics.contentDescription
import androidx.compose.ui.semantics.semantics
import androidx.compose.ui.text.AnnotatedString
import androidx.compose.ui.text.SpanStyle
Expand Down Expand Up @@ -108,7 +109,11 @@ fun HrefDynamicText(
.verticalScroll(rememberScrollState())
.testTag("hrefDynamicText")
.then(pressIndicator)
.semantics(mergeDescendants = true) {}
.semantics(mergeDescendants = true) {
if (!linkUrl.isEmpty()) {
contentDescription = "$text1 $text2 $linkText link $linkUrl"
}
}
.let {
val urlInText =
annotatedStringWithLinks
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/values-et/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,7 @@
<string name="main_accessibility_link_text">Rohkem infot leiab </string>
<string name="main_accessibility_link_url">https://www.id.ee/ligipaasetavuse-teatis/</string>
<string name="main_accessibility_link_tag">ligipääsetavuse teatisest</string>
<string name="main_accessibility_introduction">RIA DigiDoc on ehitatud nii, et see vastaks WCAG 2.1 AA juurdepääsetavuse suunistele. See tähendab, et RIA DigiDoc rakenduse arendamisel on kasutatud põhimõtteid, et see oleks kasutatav ilma nägemisvõimeta, piiratud nägemisvõimega, piiratud liikumisvõime või jõuga jms.</string>
<string name="main_accessibility_introduction">RIA DigiDoc on ehitatud nii, et see vastaks EN 301 549 juurdepääsetavuse suunistele. See tähendab, et RIA DigiDoc rakenduse arendamisel on kasutatud põhimõtteid, et see oleks kasutatav ilma nägemisvõimeta, piiratud nägemisvõimega, piiratud liikumisvõime või jõuga jms.</string>
<string name="main_accessibility_introduction_2">Juurdepääsetavust on võimalik parandada oma nutiseadmesse sisseehitatud abivahendeid kasutades. Alljärgnevalt ülevaade põhilistest abivahenditest.</string>
<string name="main_accessibility_introduction_screen_reader_title">Ekraanilugeja</string>
<string name="main_accessibility_introduction_screen_reader_introduction">Ekraanilugeja on programm, mille ülesandeks on muuta nutiseadme ekraanil kujutatavat informatsiooni kasutajale sobivaks väljundiks – näiteks kõneks. Eelkõige on see abivahend vaegnägijate jaoks.</string>
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,7 @@
<string name="main_accessibility_link_text">More information can be found on </string>
<string name="main_accessibility_link_url">https://www.id.ee/ligipaasetavuse-teatis/</string>
<string name="main_accessibility_link_tag">here</string>
<string name="main_accessibility_introduction">RIA DigiDoc is designed to comply with the WCAG 2.1 AA accessibility guidelines. This means that the RIA DigiDoc application has been developed using the principles that the application should be usable by the blind and people with visual, mobility, and strength impairments.</string>
<string name="main_accessibility_introduction">RIA DigiDoc is designed to comply with the EN 301 549 accessibility guidelines. This means that the RIA DigiDoc application has been developed using the principles that the application should be usable by the blind and people with visual, mobility, and strength impairments.</string>
<string name="main_accessibility_introduction_2">Accessibility can be improved by using built-in assistive tools on your smart device. You can find an overview of the main assistive tools below.</string>
<string name="main_accessibility_introduction_screen_reader_title">Screen reader</string>
<string name="main_accessibility_introduction_screen_reader_introduction">A screen reader is a program that converts the information on the screen of a smart device into a user-friendly output, for instance, into speech. In particular, it is a tool for the visually impaired.</string>
Expand Down
Loading