fix: normalize Docker Hub single-component refs with library/ prefix#1946
Open
knp-sap wants to merge 1 commit into
Open
fix: normalize Docker Hub single-component refs with library/ prefix#1946knp-sap wants to merge 1 commit into
knp-sap wants to merge 1 commit into
Conversation
When docker.io is explicitly specified as the hostname with a single-component repository name (e.g. docker.io/bash:5.3.9), ParseRef now correctly normalizes it to docker.io/library/bash:5.3.9. Previously, only bare image names (bash:5.3.9) received the library/ prefix via DockerLibraryReferenceRegexp. When docker.io was explicit, the reference matched ReferenceRegexp instead, which did not perform Docker Hub normalization. This caused downstream tools (e.g. OCM CLI component transfers) to fail when resolving official Docker Hub images specified with an explicit docker.io host. Signed-off-by: Kostadin Plachkov <kostadin.plachkov@sap.com>
knp-sap
force-pushed
the
fix/docker-hub-library-prefix
branch
from
1409488 to
c23ba9c
Compare
Contributor
|
Interesting. Did this cause any problems anywhere? |
jakobmoellerdev
approved these changes
May 26, 2026
Comment on lines
+133
to
+135
| if (spec.Host == dockerHubDomain || spec.Host == dockerHubLegacyDomain) && !strings.Contains(spec.Repository, "/") { | ||
| spec.Repository = "library" + grammar.RepositorySeparator + spec.Repository | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| if (spec.Host == dockerHubDomain || spec.Host == dockerHubLegacyDomain) && !strings.Contains(spec.Repository, "/") { | |
| spec.Repository = "library" + grammar.RepositorySeparator + spec.Repository | |
| } | |
| needsDockerLibraryPath := pec.Host == dockerHubDomain || spec.Host == dockerHubLegacyDomain) && !strings.Contains(spec.Repository, "/") | |
| // inject library path segment into the repository part of the parsed ref. | |
| // for docker, images are resolved including a "library" path segment. This segment needs to be | |
| // added into the Repository field, otherwise the lookup would fail in case of docker's image registry | |
| if needsDockerLibraryPath { | |
| spec.Repository = "library" + grammar.RepositorySeparator + spec.Repository | |
| } |
Contributor
There was a problem hiding this comment.
added docs & a more understandable naming
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When docker.io is explicitly specified as the hostname with a single-component repository name (e.g. docker.io/bash:5.3.9), ParseRef now correctly normalizes it to docker.io/library/bash:5.3.9.
Previously, only bare image names (bash:5.3.9) received the library/ prefix via DockerLibraryReferenceRegexp. When docker.io was explicit, the reference matched ReferenceRegexp instead, which did not perform Docker Hub normalization.