-
Notifications
You must be signed in to change notification settings - Fork 26
update sandbox run error handling and fixes for docsum and codegen workflows #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com>
Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com>
Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com>
Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com>
Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com>
Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates sandbox run error handling and adds fixes for document summarization (docsum) and code generation (codegen) workflows. The changes improve user experience through better error handling, enhanced debugging capabilities, and fixes for specific OPEA service workflows.
- Implements automatic namespace deletion and redeployment for sandboxes when conflicts occur
- Adds comprehensive pod dependency analysis and improved debug logs interface
- Fixes docsum and codegen workflow configurations and service mappings
Reviewed Changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| studio-frontend/packages/ui/src/views/debuglogs/index.jsx | Adds dependencies column to pod logs table and improves modal layout |
| studio-frontend/packages/ui/src/views/canvas/index.jsx | Handles duplicated flow type preservation for proper canvas routing |
| studio-frontend/packages/ui/src/views/canvas/CanvasHeader.jsx | Updates duplicate flow logic to preserve original flow type |
| studio-frontend/packages/ui/src/ui-component/table/FlowListTable.jsx | Adds automatic redeployment handling for namespace conflicts |
| studio-frontend/packages/ui/src/ui-component/button/FlowListMenu.jsx | Updates duplicate flow logic to preserve original flow type |
| studio-frontend/packages/server/src/nodes/llm_codegen.js | Fixes codegen service name and model configuration |
| studio-backend/app/utils/namespace_utils.py | Implements comprehensive pod failure detection and monitoring |
| studio-backend/app/services/namespace_service.py | Adds namespace deletion before redeployment logic |
| studio-backend/app/routers/debuglog_router.py | Implements detailed pod dependency analysis |
| app-backend/megaservice.py | Adds file input support and improves docsum request handling |
Comments suppressed due to low confidence (1)
studio-backend/app/routers/debuglog_router.py:151
- The return statement has a third empty list parameter, but the function signature suggests it should only return two values (success boolean and failed_pods list).
dependencies.append(target_pod.metadata.name)
siawchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* update sandbox run error handling and fixes for docsum and codegen workflows (opea-project#69) * update setup playbooks Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com> * debuglogs to display the connections between pods Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com> * fix chat history bug and duplicate workflow bug Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com> * fix genai-studio ansible to include create-ssh-secrets playbook Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com> * update to sandbox run error handling Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com> * fix for docum and codegen workflows Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com> --------- Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com> * fix for agent think card 1. filter tool call in final output 2. if streaming response in progress, keep showing response is generating message 3. if final output no answer, print iteration limit reached without final answer Signed-off-by: cheehook <chee.hoo.kok@intel.com> * Revert "Merge branch 'main' into agentqna_ui_fix" This reverts commit fe0d83c, reversing changes made to 27f8d63. * Revert "Revert "Merge branch 'main' into agentqna_ui_fix"" This reverts commit a0e1cd5. * fix wrongly merge conflict --------- Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com> Signed-off-by: cheehook <chee.hoo.kok@intel.com> Co-authored-by: wanhakim <wan.abdul.hakim.b.wan.arif@intel.com>
* update setup playbooks Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com> * debuglogs to display the connections between pods Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com> * fix chat history bug and duplicate workflow bug Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com> * fix genai-studio ansible to include create-ssh-secrets playbook Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com> * update to sandbox run error handling Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com> * fix for docum and codegen workflows Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com> * temporary hardcoding agent comp image to v1.3 Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com> * Agentqna UI fix (#18) * update sandbox run error handling and fixes for docsum and codegen workflows (#69) * update setup playbooks Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com> * debuglogs to display the connections between pods Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com> * fix chat history bug and duplicate workflow bug Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com> * fix genai-studio ansible to include create-ssh-secrets playbook Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com> * update to sandbox run error handling Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com> * fix for docum and codegen workflows Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com> --------- Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com> * fix for agent think card 1. filter tool call in final output 2. if streaming response in progress, keep showing response is generating message 3. if final output no answer, print iteration limit reached without final answer Signed-off-by: cheehook <chee.hoo.kok@intel.com> * Revert "Merge branch 'main' into agentqna_ui_fix" This reverts commit fe0d83c, reversing changes made to 27f8d63. * Revert "Revert "Merge branch 'main' into agentqna_ui_fix"" This reverts commit a0e1cd5. * fix wrongly merge conflict --------- Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com> Signed-off-by: cheehook <chee.hoo.kok@intel.com> Co-authored-by: wanhakim <wan.abdul.hakim.b.wan.arif@intel.com> * fix UI choice on sandbox app launch, clean up printouts and fix compose Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com> * enhance click deploy flow Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com> * update app fe's Summarize Content view Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com> * fix caching issues in studio's nginx Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com> * added playright tests for docsum and codegen Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com> * fixing bugs and enhancing clickdeploy experience Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com> * fix docsum and eventstreaming in compose deployment Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com> * fix api call bugs and updated data management web files display Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com> * updated test file for little red riding hood typo Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com> --------- Signed-off-by: wwanarif <wan.abdul.hakim.b.wan.arif@intel.com> Signed-off-by: cheehook <chee.hoo.kok@intel.com> Co-authored-by: cheehook <chee.hoo.kok@intel.com>
No description provided.