Skip to content

Potential fix for code scanning alert no. 427: Uncontrolled data used in path expression #2362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZePan110 merged 1 commit into from
Dec 16, 2025
Merged

Potential fix for code scanning alert no. 427: Uncontrolled data used in path expression #2362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion EdgeCraftRAG/edgecraftrag/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,14 @@ def get_prompt_template(model_path, prompt_content=None, template_path=None, ena
if prompt_content is not None:
template = prompt_content
elif template_path is not None:
template = Path(template_path).read_text(encoding=None)
# Safely load the template only if it is inside /templates (or other safe root)
safe_root = "/templates"
normalized_path = os.path.normpath(os.path.join(safe_root, template_path))
if not normalized_path.startswith(safe_root):
raise ValueError("Template path is outside of the allowed directory.")
if not os.path.exists(normalized_path):
raise FileNotFoundError("Template file does not exist.")
template = Path(normalized_path).read_text(encoding=None)
else:
template = DEFAULT_TEMPLATE
tokenizer = AutoTokenizer.from_pretrained(model_path)
Expand Down