Skip to content

Conversation

@errt
Copy link
Collaborator

@errt errt commented Oct 21, 2025

Hermes will be moved to a repository of its own to simplify OPAL maintenance.

@errt errt added this to the Release 8.0.0 milestone Oct 21, 2025
@errt errt marked this pull request as ready for review December 17, 2025 13:56
Copy link
Collaborator

@johannesduesing johannesduesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a few remaining occurrances of Hermes, some of which might be on purpose - i still wanted to briefly discuss this:

  • There are two files mapping.hermes.txt and results.hermes.txt in the .gitignore
  • Hermes Documentation is still part of the website - i guess this is intentional and makes sense to me
  • bi/src/test/fixtures-java/projects/metrics.fanin_fanout/readme.md explicitly mentiones the path DEVELOPING_OPAL/tools/.../Hermes
  • The InvokedynamicRewritingExecutionTest explicitly executes Hermes via an in-memory class loader - this should not be part of OPALs IT tests anymore, should it?
  • DEVELOPING_OPAL/validate/src/it/resources contains a fixture file called hermes-test-fixtures.json

@errt
Copy link
Collaborator Author

errt commented Dec 18, 2025

Thanks!

  • There are two files mapping.hermes.txt and results.hermes.txt in the .gitignore
    • I removed them since they don't exist for me so might be outdated anyway
  • Hermes Documentation is still part of the website - i guess this is intentional and makes sense to me
    • Yes, I kept that intentionally. Hermes is still part of the OPAL family, just maintained separately. We can think of changing the details when we update the website.
  • bi/src/test/fixtures-java/projects/metrics.fanin_fanout/readme.md explicitly mentiones the path DEVELOPING_OPAL/tools/.../Hermes
  • The InvokedynamicRewritingExecutionTest explicitly executes Hermes via an in-memory class loader - this should not be part of OPALs IT tests anymore, should it?
    • Since this seems to execute it from classfiles/OPAL-MultiJar-SNAPSHOT-01-04-2018.jar, I think we can keep it.
  • DEVELOPING_OPAL/validate/src/it/resources contains a fixture file called hermes-test-fixtures.json
    • This is referenced by the InvokedynamicRewritingExecutionTest, so see above.

Copy link
Collaborator

@johannesduesing johannesduesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the latest discussion and changes, this looks good to me 👍

@errt errt added this pull request to the merge queue Dec 19, 2025
Merged via the queue into develop with commit fb2c28d Dec 19, 2025
2 checks passed
@errt errt deleted the removal/hermes branch December 19, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants