Skip to content

FLIP 341: Add 128-bit fixed-point types to Cadence #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SupunS merged 5 commits into from
Aug 29, 2025
Merged

FLIP 341: Add 128-bit fixed-point types to Cadence #342

SupunS merged 5 commits into from
Aug 29, 2025

Conversation

@SupunS
Copy link
Member

@SupunS SupunS commented Aug 15, 2025 •
edited
Loading

This FLIP is tracked by: #341

@SupunS SupunS self-assigned this Aug 15, 2025
@SupunS SupunS requested review from a team and dete August 15, 2025 22:40
@vishalchangrani
Copy link
Contributor

vishalchangrani commented Aug 15, 2025

lgtm

@SupunS SupunS changed the title FLIP 341: Add 128-bit Fixed-point Types to Cadence FLIP 341: Add 128-bit fixed-point types to Cadence Aug 15, 2025
turbolent
turbolent approved these changes Aug 18, 2025
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

What was the reasoning behind picking a scale of 24? Might be good to add some sort of reasoning, even if it's just something like "we chose a value that is practical/sensible"

@SupunS SupunS mentioned this pull request Aug 18, 2025
Closed
1 task
dete
dete reviewed Aug 21, 2025
View reviewed changes
@SupunS @dete
Add detailed explanation on choosing a 24 scale
e4c58e1 
Co-authored-by: Dieter Shirley <dete@dapperlabs.com>
dete
dete reviewed Aug 21, 2025
View reviewed changes
@SupunS @dete
Update the explanation
70e8eff 
Co-authored-by: Dieter Shirley <dete@dapperlabs.com>
@SupunS SupunS mentioned this pull request Aug 22, 2025
Merged
6 tasks
@vishalchangrani
Copy link
Contributor

vishalchangrani commented Aug 28, 2025 •
edited
Loading

hi folks - Please add any comments or questions you have about this FLIP. This FLIP will be marked as Accepted by EOD tomorrow (8/29/2025) if there are no outstanding questions or comments that need to be addressed.
Thank you

@SupunS
Copy link
Member Author

SupunS commented Aug 29, 2025 •
edited
Loading

Thanks everyone for the feedback so far! This FLIP has been open for a while, and there hasn't been any objections for this new feature addition. Thus, we'll consider this FLIP as approved! 🎉

You can follow the implementation progress at onflow/cadence#4131

@SupunS SupunS merged commit 03baf36 into main Aug 29, 2025
@SupunS SupunS deleted the supun/fix128 branch August 29, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dete dete dete left review comments

@turbolent turbolent turbolent approved these changes

@joshuahannan joshuahannan joshuahannan approved these changes

Assignees

@SupunS SupunS

Labels

flip: cadence

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@SupunS @vishalchangrani @turbolent @dete @joshuahannan