Fix calculation per second interest rate #116
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mts1715
requested review from
Gornutz,
Kay-Zee,
UlyanaAndrukhiv and
liobrasil
6 tasks
UlyanaAndrukhiv
left a comment
UlyanaAndrukhiv
left a comment
There was a problem hiding this comment.
Looks good, left some minor comments
Comment on lines
27
to
29
| access(all) let TEN_DAYS: Fix64 = 864_000.0 | ||
| access(all) let THIRTY_DAYS: Fix64 = 2_592_000.0 // 30 * 86400 | ||
| access(all) let ONE_YEAR: Fix64 = 31_557_600.0 // 365.25 * 86400 |
There was a problem hiding this comment.
Maybe let’s move these time constants to a common file (cadence/tests/test_helpers.cdc) so we can reuse them across other tests and avoid duplication.
If you apply this proposal, please check the test files for duplicated constant declarations and remove them.
| // - 9% APY → (1 + 0.09 / 31_557_600) ^ 31_557_600 - 1 ≈ 9.42% effective rate | ||
| // - Spread should be approximately 1% | ||
| let ONE_YEAR: Fix64 = 31536000.0 | ||
| let ONE_YEAR: Fix64 = 31_557_600.0 // 365.25 days |
There was a problem hiding this comment.
Once we move ONE_YEAR to the common file (cadence/tests/test_helpers.cdc), we won’t need to declare it in every test file individually.
So we can safely remove this line.
Comment on lines
437
to
440
| Test.assert( | ||
| growthDiff <= 0.01, | ||
| message: "Growth should be ~652.54706806. Actual: \(actualGrowth)" | ||
| ) |
There was a problem hiding this comment.
I guess we should keep this assert with growth, or just updated it like you did for growthRate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #110
Description
Fixed the wrong seconds in year used in the method FlowCreditMarket->perSecondInterestRate:
perSecondScaledValue = yearlyRate / 31536000.0 // 365.0 * 24.0 * 60.0 * 60.0by
perSecondScaledValue = yearlyRate / 31_557_600.0 // 365.25 * 24.0 * 60.0 * 60.0