Backport scripts for getting position IDs and position details#296
Open
illia-malachyn wants to merge 6 commits intomainfrom
Open
Backport scripts for getting position IDs and position details#296illia-malachyn wants to merge 6 commits intomainfrom
illia-malachyn wants to merge 6 commits intomainfrom
Conversation
Since the pool contract does not remove positions from its dictionary on close (balance keys persist with zero values), the previous scripts returned stale/closed position IDs. Rename to get_open_position_ids and get_open_positions_by_ids, and filter by checking for non-zero balances so only truly open positions are returned.
Collaborator
Author
|
@nialexsan is this a correct way to return only open positions? We don't delete closed positions on |
Member
jordanschalm
left a comment
jordanschalm
left a comment
There was a problem hiding this comment.
I assume we will want to port @nialexsan's closePosition functionality to main at some point, so I would hold off on implementing a separate mechanism to find closed positions. We should be able to largely retain the scripts you made for the v0 version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backporting this branch with a difference that in this PR, we filter open positions explicitly, as FlowALPv0 behavior is different on main