deployment specs and back compat tests

[nialexsan]

Closes: #???

Description

---

For contributor use:

• Targeted PR against master branch
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the standards mentioned here.
• Updated relevant documentation
• Re-reviewed Files changed in the Github PR explorer
• Added appropriate labels

[jordanschalm]

Looks good. Have you tried this with a non-upgradeable contract version, and verified the test fails as expected?

I ask because there are fork tests on the main branch that do the same (deploy a contract that is not upgradeable w.r.t. the current Mainnet version) and they pass.

[nialexsan]

yes, I tested it with non-upgradable changes and it throws an expected error:

error: assertion failed: given value is: I.Test.Test.Error(message: "[Error Code: 1101] error caused by: 1 error occurred:
  * transaction execute failed: [Error Code: 1101] cadence runtime error: Execution failed:
error: cannot deploy invalid contract
 --> 64f2906b0b0debaa98c44da1b8097d0b3c0f1d0316f808418a0938b0a9a79c3a:7:20
  |
7 |                     signer.contracts.update(name: \"FlowALPMath\", code: \"61636365737328616c6c2920636f6e747261637420466c6f77414c504d617468207b0a0a202020206163636573732873656c6629206c657420756669783634537465703a20554669783132380a202020206163636573732873656c6629206c65742075666978363448616c66537465703a20554669783132380a0a2020202061636365737328616c6c29206c657420646563696d616c733a2055496e74380a2020202061636365737328616c6c29206c657420756669783634446563696d616c733a2055496e74380a0a202020202f2f2f2044657072... 
  |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: found new field `max` in `FlowALPMath`
  --> 6b00ff876c299c61.FlowALPMath:14:20
   |
14 |     access(all) let max: UFix128
   |                     ^^^

Was this error unhelpful?
Consider suggesting an improvement here: https://github.com/onflow/cadence/issues.


")
  --> 7465737400000000000000000000000000000000000000000000000000000000:41:4                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                     

it could be that at that pinned height in the test the contract was compatible with the changes in the main