Fix flaky test_supervisor_stale_uuid_does_not_panic test#291
Draft
jordanschalm wants to merge 1 commit intomainfrom
Draft
Fix flaky test_supervisor_stale_uuid_does_not_panic test#291jordanschalm wants to merge 1 commit intomainfrom
jordanschalm wants to merge 1 commit intomainfrom
Conversation
The supervisor's initial tick (scheduled at timestamp+1s during setup) could fire during intermediate block commits before the rebalancer was deleted, consuming the cron boundary. The subsequent 1-hour advance then failed to cross another boundary, so the supervisor never ran after the UUID became stale. Fix by flushing the initial tick before creating the stale UUID, using baseline-relative event assertions, and advancing by 3601s (just over 1 hour) to guarantee crossing a cron boundary. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asked Claude to look into a seemingly flaky test. I haven't looked into this much, and haven't seen the test failure again. Revisit if flakiness recurs.