Use PROJECT_*_DIR instead of CMAKE_*_DIR to support subproject builds#458
Open
mschilling0 wants to merge 1 commit intooneapi-src:masterfrom
Open
Use PROJECT_*_DIR instead of CMAKE_*_DIR to support subproject builds#458mschilling0 wants to merge 1 commit intooneapi-src:masterfrom
mschilling0 wants to merge 1 commit intooneapi-src:masterfrom
Conversation
Replace CMAKE_[SOURCE/BINARY]_DIR usage with PROJECT_[SOURCE/BINARY]_DIR to support subproject builds. This helps make the project usable as a subproject (e.g. via add_subdirectory or FetchContent) without polluting the parent build tree. Signed-off-by: Schilling, Matthew <matthew.schilling@intel.com>
Contributor
Author
|
Sorry for the large change - avoids the need for this patch. https://github.com/intel/pti-gpu/blob/master/sdk/cmake/levelzero_version_fix.patch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
CMAKE_[SOURCE/BINARY]_DIRusage withPROJECT_[SOURCE/BINARY]_DIRto support subproject builds. This helps make the project usable as a subproject (e.g. via add_subdirectory or FetchContent) without polluting the parent build tree.