[HCR-426] 함수 시그니처 변경#73
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the run_recommendation_and_publish_to_kafka function to accept and propagate an optional trace_id for improved logging and tracking. The trace_id is passed to the Kafka publishing function and included in the error log context. Review feedback suggests extending this propagation to the get_recommendation call to ensure full observability across the recommendation logic. Additionally, there is a concern that the current exception handling block may be redundant if the underlying functions already catch and handle all exceptions internally.
|
|
||
|
|
||
| async def run_recommendation_and_publish_to_kafka(member_id: int) -> None: | ||
| async def run_recommendation_and_publish_to_kafka(member_id: int, trace_id: str | None = None) -> None: |
Comment on lines
+152
to
+158
| logger.error( | ||
| "recommendation: 백그라운드 추천/Kafka 실패 member_id=%s trace_id=%s: %s", | ||
| member_id, | ||
| (trace_id or "").strip(), | ||
| e, | ||
| exc_info=True, | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝작업 내용
👀변경 사항
🎫 Jira Ticket
#️⃣관련 이슈