[HCR-421] v1.1.2#66
Closed
rettooo wants to merge 1 commit into
Closed
Conversation
rettooo
added
🏷️ release
Merged
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Kafka payload in the recommendation service to include a traceId. A critical issue was identified where the trace_id variable is used in the payload without being defined in the function scope or passed as an argument, which will lead to a NameError at runtime.
| logger.warning("recommendation: Kafka 미설정, 발행 스킵 member_id=%s", member_id) | ||
| return | ||
| payload = {"memberId": member_id, **response.model_dump(by_alias=True)} | ||
| payload = {"traceId": trace_id, "memberId": member_id, **response.model_dump(by_alias=True)} |
There was a problem hiding this comment.
trace_id 변수가 정의되지 않은 상태에서 사용되고 있습니다. publish_recommendation_to_kafka 함수의 매개변수 목록에 trace_id가 없으며, 함수 내부에서도 선언되지 않았습니다. 이로 인해 해당 코드가 실행될 때 NameError가 발생합니다. 호출부에서 trace_id를 전달하도록 수정하거나 함수 내에서 적절히 정의해야 합니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝작업 내용
👀변경 사항
🎫 Jira Ticket
#️⃣관련 이슈