-
Notifications
You must be signed in to change notification settings - Fork 0
[HSC-423] user-log publish/admin 전달 비동기 분리 및 executor 계측 분리 #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
23 changes: 23 additions & 0 deletions
23
...java/site/holliverse/customer/application/usecase/log/AdminLogFeatureDispatchService.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| package site.holliverse.customer.application.usecase.log; | ||
|
|
||
| import lombok.RequiredArgsConstructor; | ||
| import org.springframework.context.annotation.Profile; | ||
| import org.springframework.scheduling.annotation.Async; | ||
| import org.springframework.stereotype.Service; | ||
| import site.holliverse.customer.integration.external.AdminLogFeaturesClient; | ||
|
|
||
| /** | ||
| * admin log-feature 별도 executor로 분리 | ||
| */ | ||
| @Service | ||
| @Profile("customer") | ||
| @RequiredArgsConstructor | ||
| public class AdminLogFeatureDispatchService { | ||
|
|
||
| private final AdminLogFeaturesClient adminLogFeaturesClient; | ||
|
|
||
| @Async("adminLogFeatureTaskExecutor") | ||
| public void dispatch(Long memberId, UserLogEventName eventName, String timestamp) { | ||
| adminLogFeaturesClient.sendLogFeature(memberId, eventName, timestamp); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -34,6 +34,18 @@ public ThreadPoolTaskExecutor userLogTaskExecutor() { | |||||
| return executor; | ||||||
| } | ||||||
|
|
||||||
| @Bean(name = "adminLogFeatureTaskExecutor") | ||||||
| public ThreadPoolTaskExecutor adminLogFeatureTaskExecutor() { | ||||||
| ThreadPoolTaskExecutor executor = new ThreadPoolTaskExecutor(); | ||||||
| executor.setCorePoolSize(4); | ||||||
| executor.setMaxPoolSize(16); | ||||||
| executor.setQueueCapacity(512); | ||||||
| executor.setThreadNamePrefix("admin-log-feature-"); | ||||||
| executor.setRejectedExecutionHandler(new java.util.concurrent.ThreadPoolExecutor.CallerRunsPolicy()); | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛡️ [개선 제안]: Executor Isolation & Reliability
Suggested change
|
||||||
| executor.initialize(); | ||||||
| return executor; | ||||||
| } | ||||||
|
|
||||||
| @Bean(name = "recommendationTaskExecutor") | ||||||
| public ThreadPoolTaskExecutor recommendationTaskExecutor() { | ||||||
| ThreadPoolTaskExecutor executor = new ThreadPoolTaskExecutor(); | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛡️ [위반 규칙]: Infrastructure Layer Registration (Rule 56)
AdminLogFeatureDispatchService는 외부 시스템(AdminLogFeaturesClient)과의 통신을 처리하는 기술적 어댑터 역할을 수행합니다. 저장소 스타일 가이드 규칙 56번에 따라 어댑터 성격의 컴포넌트에는@Service를 사용하지 않아야 하며,@Configuration클래스에서@Bean으로 등록해야 합니다. 또한, 아키텍처 경계를 명확히 하기 위해 해당 클래스를infrastructure패키지로 이동하는 것을 권장합니다.References