[HSC-416] customer 런타임 async executor 등록 경로 고정#270
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
이번 풀 리퀘스트는 비동기 실행 설정을 CustomerRuntimeInfraConfiguration으로 통합하고 기존의 중복된 설정 파일과 대시보드 문서를 정리하는 작업을 포함하고 있습니다. 하지만 SecurityConfig에서 metrics, prometheus와 같은 Actuator 엔드포인트를 화이트리스트에 추가하여 인증 없이 외부에 노출한 설정은 내부 운영 정보 유출의 위험이 있는 심각한 보안 취약점으로 지적되었습니다. 해당 엔드포인트들에 대해 관리자 권한 제한이나 IP 필터링 등의 적절한 접근 제어를 적용해야 합니다.
🧪 Test Coverage Report (JaCoCo)
Package line spark (sample): 📦 Package coverage (worst 10)
🧨 Lowest coverage classes (worst 10)
🧩 Changed files coverage breakdown (3 files)
🔎 HTML 리포트: Actions → Artifacts → |
This was referenced Mar 29, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝작업 내용
userLogTaskExecutor,recommendationTaskExecutor)를CustomerRuntimeInfraConfiguration으로 이동@EnableAsync를 함께 선언해 async infra 등록 경로 단일화AsyncConfig제거👀변경 사항
CustomerMonitoringBinder가 요구하는userLogTaskExecutorbean이 customer 런타임에서 항상 같은 경로로 등록 정리UserLogService의@Async("userLogTaskExecutor")와RecommendationService의recommendationTaskExecutor도 동일한 runtime config 사용flywayMigrate/generateJooq의 DB 의존성 때문에 별도 환경 검증🎫 Jira Ticket
#️⃣관련 이슈