v1.7.0#266
Merged
Merged
Conversation
[HCR-406] 웰컴쿠폰 지급 및 쿠폰 패키지 분리
… refactor/HSC-404 # Conflicts: # src/main/java/site/holliverse/admin/application/usecase/ChurnCouponIssueProcessor.java
…HSC-404 # Conflicts: # src/main/java/site/holliverse/admin/application/usecase/ChurnCouponIssueProcessor.java
[HSC-404] 전역 예외처리 구조 개선 및 인증/검증 응답 표준화
tkv00
added
🔥 priority: P0
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 Pull Request는 Holliverse Customer 서비스의 운영 안정성과 개발 효율성을 크게 향상시키는 중요한 변경 사항들을 포함합니다. 서비스 전반에 걸쳐 상세한 모니터링 메트릭을 도입하여 시스템 상태를 실시간으로 파악할 수 있게 되었으며, 체계적인 오류 처리 구조를 구축하여 예외 발생 시 원인 분석 및 대응을 용이하게 했습니다. 또한, 신규 회원 유입을 장려하기 위한 환영 쿠폰 지급 기능을 추가하고, API 입력 유효성 검증을 강화하여 서비스의 견고함을 높였습니다. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The coupon module was updated to have a dependency on admin module's AdminException and AdminErrorCode. This violates the architecture rule that each domain should be independent and not depend on other domain modules. To fix this, the coupon module should define its own CouponException and CouponErrorCode and use them instead of AdminException and AdminErrorCode.
Comment on lines
+6
to
+7
| import site.holliverse.admin.error.AdminErrorCode; | ||
| import site.holliverse.admin.error.AdminException; |
There was a problem hiding this comment.
[위반 규칙]: Dependency Direction (의존성 방향 규칙 위반)
[문제 이유]:
새로 추가된 coupon 도메인 모듈이 admin 모듈의 AdminException 및 AdminErrorCode에 직접 의존하고 있습니다. 프로젝트 아키텍처 규칙에 따라 각 도메인은 서로 독립적이어야 하며, admin이나 customer가 아닌 공통 모듈이 특정 도메인에 의존해서는 안 됩니다. 이러한 의존성은 향후 모듈 간 결합도를 높여 유지보수를 어렵게 만들고 순환 참조의 위험을 야기할 수 있습니다.
[해결 제안]:
coupon 모듈 내에 자체적인 CouponException과 CouponErrorCode를 정의하고, CouponGrantService 내에서 AdminException 대신 이를 사용하도록 수정하는 것을 권장합니다.
예를 들어, coupon/error 패키지를 생성하고 관련 클래스를 정의한 후 아래와 같이 임포트를 수정할 수 있습니다.
Suggested change
| import site.holliverse.admin.error.AdminErrorCode; | |
| import site.holliverse.admin.error.AdminException; | |
| import site.holliverse.coupon.error.CouponErrorCode; | |
| import site.holliverse.coupon.error.CouponException; |
References
- Customer code 🚫 import/depend on Admin code. Admin code 🚫 import/depend on Customer code. Shared utils go to
sharedorshared.domainonly. (새로운coupon모듈이admin모듈에 의존하고 있어 규칙을 위반합니다.) (link)
🧪 Test Coverage Report (JaCoCo)
Package line spark (sample): 📦 Package coverage (worst 10)
🧨 Lowest coverage classes (worst 10)
🧩 Changed files coverage breakdown (71 files)
🔎 HTML 리포트: Actions → Artifacts → |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝작업 내용
👀변경 사항
🎫 Jira Ticket
#️⃣관련 이슈