fix: save a new form version when a form is replaced#3075
Open
kelvin-muchiri wants to merge 1 commit into
Open
fix: save a new form version when a form is replaced#3075kelvin-muchiri wants to merge 1 commit into
kelvin-muchiri wants to merge 1 commit into
Conversation
Previously, replacing a form whose XLSForm or XML carried the same version string as an existing XFormVersion row silently swallowed the unique_together IntegrityError in create_xform_version, leaving only the overwritten dd.xls/xml behind with no audit trail. Auto-bump the version to "<original>-N" (smallest unused N >= 2) when a replacement would otherwise collide.
kelvin-muchiri
force-pushed
the
bump-version-on-form-replace
branch
from
f8afe4a to
ff6e675
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Previously, replacing a form whose XLSForm or XML carried the same version string as an existing XFormVersion row silently swallowed the unique_together IntegrityError in create_xform_version, leaving only the overwritten dd.xls/xml behind with no audit trail.
Auto-bump the version to "-N" (smallest unused N >= 2) when a replacement would otherwise collide.
Steps taken to verify this change does what is intended
Side effects of implementing this change
Before submitting this PR for review, please make sure you have:
Closes #3076