Security: Object permission bypass when fetching widgets by key#3074
Open
tomaioo wants to merge 1 commit into
Open
Security: Object permission bypass when fetching widgets by key#3074tomaioo wants to merge 1 commit into
key#3074tomaioo wants to merge 1 commit into
Conversation
The `list()` method returns a widget looked up by `key` (`get_object_or_404(Widget, key=key)`) without calling `self.check_object_permissions()` or filtering through permission-aware queryset logic. An attacker who can guess or obtain a widget key may read widget data they are not authorized to access (IDOR). Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Object permission bypass when fetching widgets by
keyProblem
Severity:
High| File:onadata/apps/api/viewsets/widget_viewset.py:L81The
list()method returns a widget looked up bykey(get_object_or_404(Widget, key=key)) without callingself.check_object_permissions()or filtering through permission-aware queryset logic. An attacker who can guess or obtain a widget key may read widget data they are not authorized to access (IDOR).Solution
Enforce object-level permission checks for key-based lookup. For example, after fetching by key, call
self.check_object_permissions(request, obj)before serialization, or fetch from a permission-filtered queryset (self.filter_queryset(self.get_queryset())) and then resolve by key.Changes
onadata/apps/api/viewsets/widget_viewset.py(modified)