AbstractColumn: support TranslatableInterface for labels#411
Open
mhvis wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #411 +/- ##
=======================================
Coverage 95.21% 95.21%
=======================================
Files 40 40
Lines 1087 1087
=======================================
Hits 1035 1035
Misses 52 52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This change allows column labels to accept TranslatableInterface types, mimicking the behavior of Symfony's core FormType. By allowing the `t()` shortcut we get these benefits in our project: - Better static analysis: Symfony's translation:extract command can now automatically pick up these keys. - Improved IDE integration. See Symfony's FormType: https://github.com/symfony/form/blob/18707d0803cf949e375cd353772acaf237afb09e/Extension/Core/Type/FormType.php#L186
mhvis
force-pushed
the
maarten-translatable-interface
branch
from
f4754d1 to
0199976
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows column labels to accept TranslatableInterface types, mimicking the behavior of Symfony's core FormType.
By allowing the
t()shortcut we get these benefits in our project:See Symfony's FormType:
https://github.com/symfony/form/blob/18707d0803cf949e375cd353772acaf237afb09e/Extension/Core/Type/FormType.php#L186