Improvements #8
Open
Improvements #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Change events from add and remove to bind and unbind - the never ones that happen a little bit later than add and sooner than remove, so that the device can be properly initialized. 2. Add default behavior, if no vm domain is specified. In this case, the script will pick the longest running vm. 3. Add monitor script, that allows for finding ports quickly. The author is darkguy2008. I modified it a bit, so that it searches for what's necessary only. 4. Add hotplug-setup script that copies usb-libvirt-hotplug to bin directory, finds usb ports and adds udev rules automatically.
Minor bug fix
Minor bug fix. - Added option to remove portlist file even if automatic udev rule addition is not selected. - The script now removes usb.portlist file before finishing if it is empty. - Now user can skip both questions with ENTER, and they will be "y" by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change events from add and remove to bind and unbind - the never ones that happen a little bit later than add and sooner than remove, so that the device can be properly initialized.
Add default behavior, if no vm domain is specified. In this case, the script will pick the longest-running vm.
Add monitor script, that allows for finding ports quickly. The author is darkguy2008. I modified it a bit, so that it searches for what's necessary only.
Add hotplug-setup script that copies usb-libvirt-hotplug to bin directory, finds usb ports and adds udev rules automatically.