Skip to content

Conversation

@ohah
Copy link
Owner

@ohah ohah commented Nov 9, 2025

docs mise 세팅 추가

@ohah ohah self-assigned this Nov 9, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces mise as the recommended tool for managing runtime versions in the ExecuteJS project. The changes add a mise.toml configuration file and update documentation to include instructions for using mise to automatically install and manage Node.js and Rust versions.

Key Changes:

  • Adds mise.toml configuration file with Node.js 22 and Rust stable
  • Updates documentation to recommend mise for automatic runtime version management
  • Provides installation instructions for mise in both README.md and development.mdx

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
mise.toml Adds mise configuration file specifying Node.js 22 and Rust stable versions
docs/docs/dev/development.mdx Adds mise installation instructions as the recommended method, moving manual installation to a separate section
README.md Updates project structure to include mise.toml, adds mise installation instructions, and updates version requirements

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings November 10, 2025 02:15
@ohah ohah changed the title docs 잘못된 설명 추가 docs 잘못된 설명 수정 Nov 10, 2025
@ohah ohah merged commit e636503 into main Nov 10, 2025
6 checks passed
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mise activate
```

이제 프로젝트 디렉토리에서 자동으로 올바른 버전의 Node.js, pnpm, Rust가 사용됩니다.
Copy link

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation incorrectly states that pnpm will be automatically managed by mise. However, the mise.toml file only includes Node.js and Rust, not pnpm. This should be updated to match the correct information from README.md line 50, which states that pnpm must be installed separately.

Suggested correction: "이제 프로젝트 디렉토리에서 자동으로 올바른 버전의 Node.js와 Rust가 사용됩니다. pnpm은 별도로 설치해야 합니다."

Suggested change
이제 프로젝트 디렉토리에서 자동으로 올바른 버전의 Node.js, pnpm, Rust가 사용됩니다.
이제 프로젝트 디렉토리에서 자동으로 올바른 버전의 Node.js와 Rust가 사용됩니다. pnpm은 별도로 설치해야 합니다.

Copilot uses AI. Check for mistakes.
ohah added a commit that referenced this pull request Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants