-
Notifications
You must be signed in to change notification settings - Fork 0
docs 잘못된 설명 수정 #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs 잘못된 설명 수정 #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces mise as the recommended tool for managing runtime versions in the ExecuteJS project. The changes add a mise.toml configuration file and update documentation to include instructions for using mise to automatically install and manage Node.js and Rust versions.
Key Changes:
- Adds
mise.tomlconfiguration file with Node.js 22 and Rust stable - Updates documentation to recommend mise for automatic runtime version management
- Provides installation instructions for mise in both README.md and development.mdx
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| mise.toml | Adds mise configuration file specifying Node.js 22 and Rust stable versions |
| docs/docs/dev/development.mdx | Adds mise installation instructions as the recommended method, moving manual installation to a separate section |
| README.md | Updates project structure to include mise.toml, adds mise installation instructions, and updates version requirements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| mise activate | ||
| ``` | ||
|
|
||
| 이제 프로젝트 디렉토리에서 자동으로 올바른 버전의 Node.js, pnpm, Rust가 사용됩니다. |
Copilot
AI
Nov 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation incorrectly states that pnpm will be automatically managed by mise. However, the mise.toml file only includes Node.js and Rust, not pnpm. This should be updated to match the correct information from README.md line 50, which states that pnpm must be installed separately.
Suggested correction: "이제 프로젝트 디렉토리에서 자동으로 올바른 버전의 Node.js와 Rust가 사용됩니다. pnpm은 별도로 설치해야 합니다."
| 이제 프로젝트 디렉토리에서 자동으로 올바른 버전의 Node.js, pnpm, Rust가 사용됩니다. | |
| 이제 프로젝트 디렉토리에서 자동으로 올바른 버전의 Node.js와 Rust가 사용됩니다. pnpm은 별도로 설치해야 합니다. |
docs mise 세팅 추가