-
Notifications
You must be signed in to change notification settings - Fork 0
playground 폴더 구조 변경 및 불필요한 코드 제거 #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the playground structure by consolidating duplicate code and reorganizing the file structure. The main objective is to merge PlaygroundGroups functionality into PlaygroundPage and extract the playground UI logic into a reusable PlaygroundWidget component.
- Extracted playground UI rendering logic into a new
PlaygroundWidgetcomponent in the widgets layer - Consolidated
PlaygroundGroupscomponent functionality intoPlaygroundPage - Created a unified
usePlaygroundStorethat manages both tabs and playground execution state - Reorganized the features/playground module structure with a dedicated model subdirectory
Reviewed Changes
Copilot reviewed 9 out of 12 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/executeJS/src/widgets/playground/ui/playground-widget.tsx | New widget component extracted from playground-page, handles UI rendering for a single playground instance |
| apps/executeJS/src/widgets/playground/ui/index.ts | Export barrel for playground widget UI |
| apps/executeJS/src/widgets/playground/index.ts | Updated to export from ui subdirectory |
| apps/executeJS/src/pages/playground/playground-page.tsx | Refactored to incorporate PlaygroundGroups functionality and use new PlaygroundWidget |
| apps/executeJS/src/pages/playground/playground-groups.tsx | Deleted file (functionality merged into playground-page) |
| apps/executeJS/src/pages/playground/index.ts | Removed export of deleted PlaygroundGroups component |
| apps/executeJS/src/features/playground/model/store.ts | New unified store managing tabs and playground state |
| apps/executeJS/src/features/playground/model/store.test.ts | Comprehensive test suite for the playground store |
| apps/executeJS/src/features/playground/model/index.ts | Export barrel for model layer |
| apps/executeJS/src/features/playground/model/const.ts | Constants for playground feature |
| apps/executeJS/src/features/playground/index.ts | Updated to export from model subdirectory |
| apps/executeJS/src/app/index.tsx | Updated to use PlaygroundPage instead of PlaygroundGroups |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* refactor: 기존 playground-page 컴포넌트 제거 및 playground-groups > playground-page로 네이밍 변경 * feat: playground store 테스트 코드 추가 * refactor: feature/playground 폴더구조 수정 - model 폴더 생성 * refactor: widgets/playground 폴더구조 수정 - ui 폴더 생성
📌 요약
📝 작업 내용
🔍 스크린샷
💡 참고 사항