[IMP] Estate: Enhance property management with relations, views, and access #1108

radet-odoo · 2026-01-01T11:39:25Z

Completed chapters 1-5 of the Odoo tutorial, including basic app creation, models, security, and UI setup.

Add estate module Configure custom module structure in Odoo 19 Introduce addons structure and ORM models Define database tables using Odoo ORM CHAPTER 1,2,3

Define model access rules for the estate module using ir.model.access.csv to control user permissions. CHAPTER 4

Make estate.property accessible from the UI with proper defaults and field constraints.

robodoo · 2026-01-01T11:39:28Z

CHAPTER 5

bit-odoo

Hello, Good Job!

i have added some comments.

no need to do separate commit for this - 3981aa4

Can you please adapt the PR meesage and title accroding to guidelines.

Thanks

bit-odoo · 2026-01-02T07:33:32Z

estate/__manifest__.py

@@ -0,0 +1,15 @@
+{
+    'name': "Real Estate",


Please follow the same quote throughout the file.

bit-odoo · 2026-01-02T07:51:39Z

estate/models/estate_property.py

+from odoo import fields, models
+from dateutil.relativedelta import relativedelta


Can you please follow these guidelines?
https://www.odoo.com/documentation/19.0/contributing/development/coding_guidelines.html#imports

bit-odoo · 2026-01-02T07:54:30Z

estate/models/estate_property.py

+    garage = fields.Boolean()
+    garden = fields.Boolean()
+    garden_area = fields.Integer()
+


unneccary diff.

bit-odoo · 2026-01-02T07:54:38Z

estate/models/estate_property.py

+    garden_orientation = fields.Selection(
+        [('north', 'North'), ('south', 'South'), ('east', 'East'), ('west', 'West')]
+    )
+


unneccary diff.

bit-odoo · 2026-01-02T07:54:53Z

estate/security/ir.model.access.csv

@@ -0,0 +1,2 @@
+id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
+access_estate_property,access_estate_property,model_estate_property,base.group_user,1,1,1,1


Should be one empty line at the EOF.

bit-odoo · 2026-01-02T07:55:01Z

estate/views/estate_menus.xml

+        </menuitem>
+
+    </data>
+</odoo>


Should be one empty line at the EOF.

bit-odoo · 2026-01-02T07:55:14Z

estate/views/estate_menus.xml

+<?xml version="1.0"?>
+<odoo>
+    <data>
+


unneccary diff.

bit-odoo · 2026-01-02T07:55:21Z

estate/views/estate_menus.xml

+                <menuitem id="estate_properties_menu_action" action="estate_property_action"/>
+            </menuitem>
+        </menuitem>
+


unneccary diff.

bit-odoo · 2026-01-02T07:55:29Z

estate/views/estate_property_views.xml

+        <field name="res_model">estate.property</field>
+        <field name="view_mode">list,form</field>
+    </record>
+</odoo>


Should be one empty line at the EOF.

Improve estate.property usability by organizing fields and adding filters. CHAPTER 6

Improve data link between related models. CHAPTER 7

CHAPTER 7

radet-odoo · 2026-01-06T08:55:59Z

Changes have been made as per the review suggestions. Thank you.

bit-odoo

Hello,
Good Work!

Can you please improve all your commit message accroding to guidelines.

Thanks

bit-odoo · 2026-01-07T06:14:41Z

estate/models/estate_property.py

+from dateutil.relativedelta import relativedelta
+from odoo import fields, models


Please do not make the same mistake repeatedly. #1108 (comment)

bit-odoo · 2026-01-07T06:18:38Z

estate/views/estate_property_views.xml

+                <field name="bedrooms" />
+                <field name="living_area" />
+                <field name="garden" />
+                <field name="garage" />
+                <field name="date_availability" />


We can make some fields optional for better visibility.

bit-odoo · 2026-01-07T06:19:09Z

estate/views/estate_property_views.xml

+                <separator />
+                <filter string="Available" name="active" domain="[('state', 'in', ['new','offer_received'])]" />
+                <filter string="postcode" name="postcode" context="{'group_by':'postcode'}" />
+


unneccary space.

- Add computed fields for total area and best offer to ensure data consistency - Implement computed validity date with inverse logic on property offers - Add onchange to assist garden-related form inputs without business logic CHAPTER - 8

- Add Cancel and Sold actions on properties with state validation - Add Accept and Refuse actions on offers with business constraints - Ensure accepted offer sets buyer and selling price, enforcing uniqueness CHAPTER - 9

- Add SQL constraints for positive prices and unique names - Add Python constraint to block selling below 90% expected price - Ensure constraints trigger on expected and selling price changes CHAPTER 10

- Add inline list view on property type to show linked properties - Display property state using statusbar widget for better clarity - Improve UX by simplifying views without changing business logic CHAPTER 11

- Improve usability by adding inline list views and statusbar widgets - Prevent invalid actions using conditional visibility and readonly rules - Enhance readability with list decorations, tag colors, and editable lists - Apply deterministic and manual ordering, plus better default search behavior CHAPTER 11

bit-odoo

Hello,
Can you please improve your PR message and title.
Thanks.

bit-odoo · 2026-01-12T11:09:13Z

estate/models/estate_property.py

+    def action_sold(self):
+        for record in self:
+            if record.state == 'cancelled':
+                raise exceptions.UserError("Cancelled properties cannot be sold.")
+            record.state = 'sold'
+        return True


It's good to make the error message translatable.
raise exceptions.UserError(_("Cancelled properties cannot be sold."))

We can use filtered() here.

if self.filtered(lamda x: x.state=="cancelled")

bit-odoo · 2026-01-12T11:10:01Z

estate/models/estate_property.py

+        for record in self:
+            if record.state == 'sold':
+                raise exceptions.UserError("Sold properties cannot be cancelled.")
+            record.state = 'cancelled'


It's good to make the error message translatable.
raise exceptions.UserError(_("Sold properties cannot be cancelled."))

We can use filtered() here.

if self.filtered(lamda x: x.state=="sold")

radet-odoo added 3 commits December 31, 2025 16:11

[ADD] estate: initial module setup and ORM configuration

987e6c2

Add estate module Configure custom module structure in Odoo 19 Introduce addons structure and ORM models Define database tables using Odoo ORM CHAPTER 1,2,3

[ADD] estate: add access rights for user groups

a94c3cd

Define model access rules for the estate module using ir.model.access.csv to control user permissions. CHAPTER 4

[ADD] estate: add UI actions, menus and defaults

8a7b04c

Make estate.property accessible from the UI with proper defaults and field constraints.

[FIX] runbot: fix checkpoints error

3981aa4

CHAPTER 5

bit-odoo reviewed Jan 2, 2026

View reviewed changes

radet-odoo added 3 commits January 2, 2026 14:59

[IMP] estate: add custom list, form, and search views

0bee4ea

Improve estate.property usability by organizing fields and adding filters. CHAPTER 6

[IMP] Add many2one relation between two tables

464369e

Improve data link between related models. CHAPTER 7

[IMP] estate: add many2many and one2many relations to properties

359d3d5

CHAPTER 7

radet-odoo changed the title ~~19.0 tutorials radet~~ [IMP] estate: Enhance property management with relational fields, views, and user access Jan 7, 2026

radet-odoo changed the title ~~[IMP] estate: Enhance property management with relational fields, views, and user access~~ [IMP] Estate: Enhance property management with relations, views, and access Jan 7, 2026

bit-odoo reviewed Jan 7, 2026

View reviewed changes

radet-odoo added 5 commits January 7, 2026 12:51

[IMP] estate: computed fields and onchanges

9d74e9c

- Add computed fields for total area and best offer to ensure data consistency - Implement computed validity date with inverse logic on property offers - Add onchange to assist garden-related form inputs without business logic CHAPTER - 8

[IMP] estate: add action buttons for property and offer states

163c6d9

- Add Cancel and Sold actions on properties with state validation - Add Accept and Refuse actions on offers with business constraints - Ensure accepted offer sets buyer and selling price, enforcing uniqueness CHAPTER - 9

[IMP] estate: enforce business rules using constraints

dff1b27

- Add SQL constraints for positive prices and unique names - Add Python constraint to block selling below 90% expected price - Ensure constraints trigger on expected and selling price changes CHAPTER 10

[IMP] estate: improve UI with inline views and widgets

6bef477

- Add inline list view on property type to show linked properties - Display property state using statusbar widget for better clarity - Improve UX by simplifying views without changing business logic CHAPTER 11

bit-odoo reviewed Jan 13, 2026

View reviewed changes

		from odoo import fields, models
		from dateutil.relativedelta import relativedelta

		@@ -0,0 +1,2 @@
		id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
		access_estate_property,access_estate_property,model_estate_property,base.group_user,1,1,1,1 No newline at end of file

[IMP] Estate: Enhance property management with relations, views, and access #1108

Are you sure you want to change the base?

[IMP] Estate: Enhance property management with relations, views, and access #1108

Uh oh!

Conversation

radet-odoo commented Jan 1, 2026

Uh oh!

robodoo commented Jan 1, 2026

Uh oh!

bit-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

radet-odoo commented Jan 6, 2026

Uh oh!

bit-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bit-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants