[ADD] estate: created the model and Initalized it with the postgre db #1107

japat-odoo · 2026-01-01T10:36:03Z

Add SQL constraints to ensure data integrity:

Expected price and offer price must be strictly positive.
Selling price must be positive.
Property type and tag names must be unique.
Added the Python constraints, but without using float_compare and float_is_zero

- The Estate Module, which is needed as of tutorials - Required fields were added, including the selection - CHAPTER 1,2,3

robodoo · 2026-01-01T10:36:06Z

-Added the list and form view for proper readability with the group feature -Added the search functionality, i.e, available and Postcode -Added the security read, write, and create rules to solve the warning message

-improved the structure of the estate property -CHAPTER 4,5,6

bit-odoo

Hello,
Good work!

No need to define a chapter in the PR message.
And can you please adapt your commit message according to guidelines?

Thanks

bit-odoo · 2026-01-02T08:03:20Z

estate/models/estate_property.py

+from odoo import models, fields
+from datetime import timedelta


Can you please follow these guidelines?
https://www.odoo.com/documentation/19.0/contributing/development/coding_guidelines.html#imports

bit-odoo · 2026-01-02T08:03:52Z

estate/views/estate_menus.xml

+        name="Properties"
+        parent="estate_first_level_menu"
+        action="estate_property_action" />
+</odoo>


Should be one empty line at the EOF.

bit-odoo · 2026-01-02T08:04:13Z

estate/views/estate_property_views.xml

+        <field name="res_model">estate.property</field>
+        <field name="view_mode">list,form</field>
+    </record>
+</odoo>


Should be one empty line at the EOF.

- Created the 'estate.property.offer' model with fields - Add a One2many relationship 'offer_ids' to the 'estate.property' model. - Implement list and form views for the offer model. - Update the property form view to display offers in a dedicated tab.

- Implemented computed fields for 'total_area' and 'best_price' to automatically aggregate property data and identify the highest offer. - Added 'validity' and 'date_deadline' to property offers with inverse logic, allowing users to define deadlines either by a date or a duration in days.

- Add an onchange method for the garden field - Fix ParseError by ensuring actions are defined before menuitems - chapter 8

bit-odoo

Hello
Nice work!
Can you please update your PR description.
Thanks

bit-odoo · 2026-01-06T09:14:41Z

estate/models/estate_property.py

+from odoo import api, fields, models
+from datetime import timedelta


Please apply these changes.-#1107 (comment)

bit-odoo · 2026-01-06T09:19:41Z

estate/models/estate_property.py

+
+    name = fields.Char(required=True)
+    description = fields.Text()
+    postcode = fields.Char()


Why is this field char() ?

Because, Sir, here in Chapter 3, we are told to have this field as a Character
https://www.odoo.com/documentation/19.0/developer/tutorials/server_framework_101/03_basicmodel.html#types
I have done the other changes
Thank You.

bit-odoo · 2026-01-06T09:24:53Z

estate/models/estate_property_offer.py

+from odoo import api, fields, models
+from datetime import timedelta


Please apply these changes here also.-#1107 (comment)

bit-odoo · 2026-01-06T09:26:20Z

estate/security/ir.model.access.csv

+estate.access_estate_property,access_estate_property,estate.model_estate_property,base.group_user,1,1,1,1
+estate.access_estate_property_type,access_estate_property_type,estate.model_estate_property_type,base.group_user,1,1,1,1
+estate.access_estate_property_tag,access_estate_property_tag,estate.model_estate_property_tag,base.group_user,1,1,1,1
+estate.access_estate_property_offer,access_estate_property_offer,estate.model_estate_property_offer,base.group_user,1,1,1,1


Should be one empty line at EOF.

bit-odoo · 2026-01-06T09:28:57Z

estate/views/estate_property_views.xml

+                    <h1>
+                        <field name="name" />
+                    </h1>
+


unneccary space.

bit-odoo · 2026-01-06T09:29:09Z

estate/views/estate_property_views.xml

+                            help="here you will get the tags" />
+                    </group>
+                    <group>
+


unneccary space.

bit-odoo · 2026-01-06T09:29:34Z

estate/views/estate_property_views.xml

+                                <field name="total_area" />
+                            </group>
+                        </page>
+


unneccary space.

bit-odoo · 2026-01-06T09:29:50Z

estate/views/estate_property_views.xml

+                        <page string="Offers">
+                            <field name="offer_ids"></field>
+                        </page>
+


unneccary space.

- Added 'Sold' and 'Cancel' buttons to estate.property. - Added 'Accept' and 'Refuse' buttons to estate.property.offer. - Implement logic to prevent selling canceled properties and vice-versa. - Update property state, selling price, and buyer when an offer is accepted.

Add SQL constraints to ensure data integrity: - Expected price and offer price must be strictly positive. - Selling price must be positive. - Property type and tag names must be unique. - Added the Python constrains but without using float_compare and float_is_zero

…ttributes - Model Ordering: - Added default ordering for properties (newest first), offers (highest price), tags, and types (alphabetical). - Implemented manual ordering for property types using a 'sequence' field and the 'handle' widget in list views. - View Enhancements: - Integrated 'statusbar' widget for property states. - Added color pickers to tags and 'no_create'/'no_edit' options to property types to prevent accidental data entry. - Enabled inline editing (editable=bottom) for offers and tags to reduce form switching. - Applied conditional decorations (colors/bold) to list views based on property status and offer values. - Business Logic & Visibility: - Used 'invisible' attributes to hide garden details when no garden is present and to hide offer buttons once processed. - Set 'readonly' on offers once a property reaches a terminal state (Offer Accepted, Sold, or Cancelled) to ensure data integrity. - Chapter 10 done, 11 (85%)

bit-odoo

Hello,
Can you please improve your PR title.
Thanks

bit-odoo · 2026-01-12T11:46:52Z

estate/models/estate_property.py

+    _check_expected_price = models.Constraint(
+        "CHECK(expected_price >= 0)",
+        "The expected price should be strictly positive",
+    )
+    _check_selling_price = models.Constraint(
+        "CHECK(selling_price >= 0)",
+        "The selling price should be strictly positive",
+    )


Please follow the coding guidelines SQL constraints are declared after the field declaration.

bit-odoo · 2026-01-12T11:48:37Z

estate/models/estate_property.py

+        copy=False,
+        required=True,
+    )
+    status = fields.Selection(


Why have you created this field? We already have a state field.

bit-odoo · 2026-01-12T11:50:49Z

estate/models/estate_property.py

+        for record in self:
+            if record.status == "cancelled":
+                raise UserError("Cancelled Property cannot be sold.")
+            else:
+                record.state = "sold"
+                record.status = "sold"


It's good to make the error message translatable.
raise UserError(_("Cancelled Property cannot be sold."))

We can use filtered() here.

if self.filtered(lamda x: x.state=="cancelled")

bit-odoo · 2026-01-12T11:51:45Z

estate/models/estate_property.py

+        for record in self:
+            if record.status == "sold":
+                raise UserError("Sold Property cannot be Cancelled.")
+            record.state = "cancelled"
+            record.status = "cancelled"


It's good to make the error message translatable.
raise UserError(_("Sold Property cannot be Cancelled."))

We can use filtered() here.

if self.filtered(lamda x: x.state=="sold")

bit-odoo · 2026-01-12T11:53:38Z

estate/models/estate_property_offer.py

+class EstatePropertyOffer(models.Model):
+    _name = "estate.property.offer"
+    _description = "Estate Property Offer"
+    _check_offer_price = models.Constraint(


Please follow the coding guidelines SQL constraints are declared after the field declaration.

bit-odoo · 2026-01-12T12:06:28Z

estate/models/estate_property_offer.py

+            date_diff = record.date_deadline - creation_date
+            record.validity = date_diff.days
+
+    def refuse_offer_action_icon(self):


Please follow the coding guidelines prefix with action_ .

[ADD] estate: created the model and Initalized it with the postgre db

a6ca236

- The Estate Module, which is needed as of tutorials - Required fields were added, including the selection - CHAPTER 1,2,3

japat-odoo added 2 commits January 1, 2026 18:15

[IMP] estate: done ui major search, list, form

26ff004

-Added the list and form view for proper readability with the group feature -Added the search functionality, i.e, available and Postcode -Added the security read, write, and create rules to solve the warning message

[IMP] estate: improvement in the code structure

dbcf3f0

-improved the structure of the estate property -CHAPTER 4,5,6

bit-odoo reviewed Jan 2, 2026

View reviewed changes

japat-odoo added 3 commits January 2, 2026 17:21

[IMP] estate: add onchange and fix parseError

37413c2

- Add an onchange method for the garden field - Fix ParseError by ensuring actions are defined before menuitems - chapter 8

bit-odoo reviewed Jan 6, 2026

View reviewed changes

japat-odoo added 3 commits January 7, 2026 19:03

bit-odoo reviewed Jan 13, 2026

View reviewed changes

		from odoo import models, fields
		from datetime import timedelta

		from odoo import api, fields, models
		from datetime import timedelta

[ADD] estate: created the model and Initalized it with the postgre db #1107

Are you sure you want to change the base?

[ADD] estate: created the model and Initalized it with the postgre db #1107

Uh oh!

Conversation

japat-odoo commented Jan 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robodoo commented Jan 1, 2026

Uh oh!

bit-odoo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bit-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bit-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

japat-odoo commented Jan 1, 2026 •

edited

Loading

bit-odoo left a comment •

edited

Loading