-
Notifications
You must be signed in to change notification settings - Fork 11.1k
[IMP] voip: add granular access rights groups #16082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 19.0
Are you sure you want to change the base?
Conversation
|
@Felicious this is ready for review! |
Felicious
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @huisit! I have a few comments on style that are super minor, and I wanted to ask you a few questions offline about the plans for rebrand, because I thought we were removing all instances of "VoIP" but I think that wasn't addressed yet in the PR (:
I'll approve and merge after the clarification!
| | Database administrators are not automatically granted administrator rights for VoIP. | ||
| | Make sure to set the correct access level for each |VOIP| user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think there's anything wrong with what you're doing here! I'm just trying to understand the reasoning for the formatting (:
-
why is the "VoIP" in line 72 without the abbr and the one with 73 with the abbr?
-
Also, did you format it with the
|to ensure these two lines are aligned?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I missed that one, thank you for catching it!
|ensures the two lines are split. When they were one line, the second sentence had a few trailing words. VS Code color codes them incorrectly with the replacement syntax, but it behaves as expected.
Co-authored-by: Felicia Kuan <feku@odoo.com>
1fe3275 to
8d4afc7
Compare
|
@Felicious I applied your changes and replied to your comment about the |

documentation task card: https://www.odoo.com/odoo/action-4043/5440261
key change @ line 57:
other @ line 79:
notes:
This 19.0 PR can be FWP up to master.