Skip to content

Conversation

@huisit
Copy link
Contributor

@huisit huisit commented Jan 22, 2026

documentation task card: https://www.odoo.com/odoo/action-4043/5440261

key change @ line 57:

  • added config subsection to explain granular access rights introduced in voip --> phone rebrand

other @ line 79:

  • renamed section below from
  • minor edit to first paragraph of said section

notes:

  • this PR targets access rights only, since it wasn't mentioned anywhere outside of OXP and has been a ticket driver
  • additional task cards/PR's will be created to address the voip --> phone rebrand

This 19.0 PR can be FWP up to master.

@huisit huisit self-assigned this Jan 22, 2026
@robodoo
Copy link
Collaborator

robodoo commented Jan 22, 2026

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team January 22, 2026 18:26
@huisit huisit added the 2 label Jan 22, 2026
@huisit huisit requested a review from Felicious January 26, 2026 18:19
@huisit
Copy link
Contributor Author

huisit commented Jan 26, 2026

@Felicious this is ready for review!

Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @huisit! I have a few comments on style that are super minor, and I wanted to ask you a few questions offline about the plans for rebrand, because I thought we were removing all instances of "VoIP" but I think that wasn't addressed yet in the PR (:

I'll approve and merge after the clarification!

Comment on lines 72 to 73
| Database administrators are not automatically granted administrator rights for VoIP.
| Make sure to set the correct access level for each |VOIP| user.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think there's anything wrong with what you're doing here! I'm just trying to understand the reasoning for the formatting (:

  1. why is the "VoIP" in line 72 without the abbr and the one with 73 with the abbr?

  2. Also, did you format it with the | to ensure these two lines are aligned?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I missed that one, thank you for catching it!
  2. | ensures the two lines are split. When they were one line, the second sentence had a few trailing words. VS Code color codes them incorrectly with the replacement syntax, but it behaves as expected.

Co-authored-by: Felicia Kuan <feku@odoo.com>
@huisit huisit force-pushed the 19.0-voip-granular-access-rights-groups-rexhu branch from 1fe3275 to 8d4afc7 Compare January 27, 2026 18:51
@huisit
Copy link
Contributor Author

huisit commented Jan 27, 2026

@Felicious I applied your changes and replied to your comment about the | formatting!
I'm planning to prepare all of the VoIP rebrand PR's at once. Is there anything else I can clarify before merging? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants