-
Notifications
You must be signed in to change notification settings - Fork 10.8k
[IMP] Contacts: Update address types #15595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
Conversation
|
@larm-odoo this is ready for review. Thanks! |
larm-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jero-odoo - great updates, just a few notes. First, I saw a bunch of app references not in bold (from the original version) so I would update all of those. The other thing is, I noticed a lot of different/additional fields on a few different runbots. I assume this is due ot localizatoin packages- fiscal and just selecting the country for the database. I would recommend explaining/calling out all the truly universal fields (unrelated to localizations) and have an admonition mentioning additional fields will be visible depending on the localiation - then you can link ot the fiscal localizaiton section. This way, this doc explains all the default fields, and none of the specific ones. This only caught my attention when the Tax ID field and 1099 field were mentioned- which didn't appear in my runbot field, and then I realized those are US related fields. That's the only major issue I saw. Approving now because I know you got this!
| - :guilabel:`Job Position`: list the job position of the :guilabel:`Individual` (only available on | ||
| :guilabel:`Individual`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just sounds awkward with Individual written a lot. maybe:
list the contact's job position. This only appears for :guilabel:Individual contacts.
| - :guilabel:`Mobile`: list mobile phone number (with country code). Make a call, send an SMS, or | ||
| WhatsApp message by hovering over the field on the saved form, and clicking on the desired option. | ||
| - :guilabel:`Email`: enter the email address with the domain. | ||
| - :guilabel:`Tax ID`: the identification number used for tax and accounting purposes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is country- specific. Exxample, in this runbot 0 there is an "ID' field, not a tax fied, then a Citizen ID field:

Perhaps for this section, you can have "universal fields" (which appear for all localizations/regions/etc) and then you can mention that other fields (give examples) are country-specific, relating to taxes and other country-specific information. Might have ot check with a PO to see what is truly 'default' since everyone has to pick a ocuntry when creating a demo database. Just a thought, since I noticed different fields.
| - :guilabel:`Email`: enter the email address with the domain. | ||
| - :guilabel:`Tax ID`: the identification number used for tax and accounting purposes. | ||
| - :guilabel:`Partner Level`: select the designated :ref:`partner <contacts/partner-assignment>` | ||
| level for this contact from the drop-down menu. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also saw a 'Title' field. Not sure if that is default or specific to the country.
| contacts can be added that are associated with a :guilabel:`Company` and related addresses. For | ||
| example, a specific contact person for the company can be listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add that this is available for both company and individual - or not mention company at all, since it is for both.
| :alt: Add a contact/address to the contact form. | ||
|
|
||
| Once an option is selected, enter the corresponding contact information that should be used for the | ||
| specified address type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 90: 'and mobile' instead of and/or
|
|
||
| .. example:: | ||
| For example, there is an :guilabel:`Opportunities` smart button, where all the opportunities | ||
| related to this customer from the *CRM* app are accessible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
183 : Members app - bold
|
|
||
| .. example:: | ||
| For example, there is an :guilabel:`Opportunities` smart button, where all the opportunities | ||
| related to this customer from the *CRM* app are accessible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| related to this customer from the *CRM* app are accessible. | |
| related to this customer from the **CRM** app are accessible. |
| should there be any related to this contact. | ||
|
|
||
| If the contact is a partner, the user can visit their partner page on the Odoo-built website by | ||
| clicking the :guilabel:`Go to Website` smart button. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| clicking the :guilabel:`Go to Website` smart button. | |
| clicking the :guilabel:`Go to Website` smart button. |
Add globe icon to smart button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could add ALL the icons to the smart buttons! =)
| that, go to the :icon:`fa-cog` :guilabel:`Action` menu at the top of the contact form, and click | ||
| :guilabel:`Archive`. | ||
|
|
||
| Then, click :guilabel:`OK` from the resulting :guilabel:`Confirmation` pop-up window. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Then, click :guilabel:`OK` from the resulting :guilabel:`Confirmation` pop-up window. | |
| Then, click :guilabel:`Archive` from the resulting :guilabel:`Confirmation` pop-up window. |
Alos, you can add the folder icon that appears next to Archive int he dorp0-down int he direciton above (with the gear).
| the main contacts page, but they can still be searched for with the :guilabel:`Archived` filter. | ||
|
|
||
| .. tip:: | ||
| A contact can be *unarchived*, if the user decides to work with them again. To do that, just |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can add the icons here, too

Docs task:https://www.odoo.com/odoo/project.task/5347418
Updating Contacts doc to reflect 18 UI changes and content guidelines
Specifically, section on address types and create new contact form