Skip to content

Conversation

@lman-odoo
Copy link
Contributor

task-5136241

@robodoo
Copy link
Collaborator

robodoo commented Dec 3, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested review from a team December 3, 2025 12:45
@lman-odoo lman-odoo requested review from auva-odoo and removed request for a team December 3, 2025 13:10
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This is only the first of two comment batches for this review! But thank you so much already for your tremendous work in this PR 🤯 🙏 !!!)

  • I think it might better (and easier) to structure the beginning of the doc a bit differently to have something that's maybe a bit closer to the options available in the Style tab. I think it would make things easier to understand, and also, for example, the search field/option also controls whether the search field is displayed at the top of the filters so it's not limited tot the "top bar". I would also rename "top bar" into "toolbar" and would maybe have something like this: (h2) Toolbar and filters (let's see if this works!) and then h3s: Categories, Filters, Toolbar. Let's maybe discuss this!

  • As discussed, let's also add a seealso for the Gelato documentation saying something like: Configure the Gelato connector in Odoo to synchronize product catalogs and automate order fulfilment with Gelato.

Comment on lines 36 to 42
To use product variants, the :guilabel:`Variants` setting **must** be activated in the Odoo *Sales*
application.

To do that, go to :menuselection:`Sales app --> Configuration --> Settings`, and locate the
:guilabel:`Product Catalog` section at the top of the page.

In that section, check the box to enable the :guilabel:`Variants` feature.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're changing this part anyways, I'd suggest to improve it even further to avoid repetitions 🙈

Suggested change
To use product variants, go to :menuselection:`Sales --> Configuration --> Settings`, then enable the :guilabel:`Variants` feature in the :guilabel:`Product Catalog` section at the top of the page.

And I would even remove the screenshot right after this

Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: sorry it seems I have posted the same comment twice and I can no longer delete my own comments (thank you GitHub ...), I can only edit it. Please ignore this one!

Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @lman-odoo, here's the second (and last) part of this first review. Thank you for your patience! As usual, feel free to reach out if anything's unclear or if you'd like to discuss any of my comments/questions!

(PS: Don't forget to avoid you/your when possible (e.g., your website, your products, etc.))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants