[FIX] hr_holidays: limit days selection for accruals to the corresponding month days #4953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…selected month This disallows the user setting accrual plans for yearly or bi-yearly and selecting a day that doesn't exist (like 30th of February). This also disallows selecting days that aren't present in every year (like 29th of February) since it only occurs once every 4 years and it would be confusing for end-users when the yearly accrual isn't triggered yearly task-5473491
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding-ibmah, it needs to be retargeted before it can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disallows the user setting accrual plans for yearly or bi-yearly and selecting a day that doesn't exist (like 30th of February).
This also disallows selecting days that aren't present in every year (like 29th of February) since it only occurs once every 4 years and it would be confusing for end-users when the yearly accrual isn't triggered yearly.
task-5473491