[FIX] web_editor: fix image upload error handling #4948
+112
−217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:17.0-fix-image-upload-error-handling-dtda, it needs to be retargeted before it can be merged. |
dtda-odoo
force-pushed
the
17.0-fix-image-upload-error-handling-dtda-v3
branch
2 times, most recently
from
9ba14fa to
da12159
Compare
dtda-odoo
force-pushed
the
17.0-fix-image-upload-error-handling-dtda-v3
branch
from
da12159 to
d0e0a80
Compare
Steps to Reproduce: 1. Open the website module. 2. Open the media upload dialog to upload an image by either double-clicking the logo or replacing the existing image. 3. Upload a large file. 4. Abort the upload before it finishes by clicking the 'Discard' button in the media dialog box. After performing these steps, a traceback is observed. Before this commit: - Image upload failures would throw uncaught exceptions. - These exceptions would interrupt the flow and result in a poor user experience with no clear feedback. - Even after clicking the discard button the image was still getting uploaded. After this commit: - Each upload is wrapped in a try-catch-finally block. - If an error occurs, it no longer breaks the flow. - The error is logged to the console for debugging purposes. - Discard button stops the upload of image. task-4752497
dtda-odoo
force-pushed
the
17.0-fix-image-upload-error-handling-dtda-v3
branch
from
d0e0a80 to
4f8229f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to Reproduce:
After performing these steps, a traceback is observed.
Before this commit:
After this commit:
task-4752497