[FIX] hr_holidays: day selection fix in accrual ux #4947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding-faavc, it needs to be retargeted before it can be merged. |
Bug reproduction steps: Timeoff->Configuration->Accrual Reports, when adding milestones you can select all days from 1 to 31 independently from the month when you selected yearly or twice a year options. Bug cause: The days are kept with selection field and this selection field takes all the values in between 1-31. Solution: Creating a new widget that extends selection field and arranges the shown days according to the received month props task - 5463057
Faruk372742
force-pushed
the
master-hr-onboarding-accrual_ux_frontend-faavc
branch
from
0b0461b to
bbe07e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug reproduction steps: Timeoff->Configuration->Accrual Reports, when adding milestones you can select all days from 1 to 31 independently from the month when you selected yearly or twice a year options.
Bug cause: The days are kept with selection field and this selection field takes all the values in between 1-31.
Solution: Creating a new widget that extends selection field and arranges the shown days according to the received month props
task - 5463057