[FIX] hr_holidays: dynamic day selection for accrual plan milestones #4946
+51
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug reproduction steps:
Bug cause:
The 'day' and 'month' fields were treated as independent selection fields. The day field used a static selection list (1-31) defined in the Python model, which did not account for the varying lengths of months. This allowed for invalid dates like February 31st to be saved in the database.
Solution:
Created a new OWL field widget 'day_selector' that extends the standard SelectionField.
task - 5468807