[FIX] hr_holidays: prevent invalid date selection in accrual plans #4944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding-raibr, it needs to be retargeted before it can be merged. |
ramezlahzy
force-pushed
the
master-hr-time-off-ux-raibr
branch
3 times, most recently
from
0d6c0d2 to
c573149
Compare
Steps to reproduce: Go to Time Off > Configuration > Accrual Plans Create or edit an accrual plan Add a milestone with “Twice a year” or “Yearly” frequency Select February as the month Notice that day 31 can be selected, creating an invalid date Bug cause: Day fields were plain Selection fields listing 1–31 regardless of the selected month, allowing invalid configurations like “31st of February”. Solution: Added a frontend field widget accrual_day that dynamically filters day options based on the selected month (leap-year aware) while reusing the core SelectMenu UI. Updated first_month_day, second_month_day, and yearly_day in the accrual level form to use widget="accrual_day" so users only see valid days for the chosen month. Kept existing Python compute methods (_compute_first_month_day, _compute_second_month_day, _compute_yearly_day) to auto-adjust values when months change, ensuring server-side correctness without schema changes. Simplified the widget to rely on SelectionField’s template (no custom <select>) and keep the default styling; no new models or database changes. Scope/Risk: Low; changes are UI-only for accrual plan day selection and leverage existing backend compute safeguards. Task-Id: 5457727
ramezlahzy
force-pushed
the
master-hr-time-off-ux-raibr
branch
from
c573149 to
223f1be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Bug cause:
The day fields used static Selection fields showing all days 1-31 regardless of the selected month, allowing invalid dates like "31st of February" to be configured.
Solution:
Task Id:5457727