[IMP] empty #4929
Open
[IMP] empty #4929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding, it needs to be retargeted before it can be merged. |
added 2 commits
December 30, 2025 11:02
Steps to reproduce: 1. Open "Employees" App 2. Click on any employee 3. Click on the "Payroll" Tab 4. Make sure "contract" date is empty Bug cause: The "button_new_contract" widget in the employee_form view is always displayed because it does not define an invisible condition. Solution: Added an invisible condition to the button_new_contract widget so it is shown only when the contract start date is set. Task: #5447352
Steps to reproduce: 1. Time Off >> Configuration >> Time Off Types >> Open any type, navigate to the Smart button Time Off >> Click on New >> Time Off Type Leads to a traceback error. Bug cause: The op function called in _search_virtual_remaining_leaves method expects two values [ie. op(value1, value2)], but only one was passed. This led to the traceback error. Solution: Passed a second parameter "value" in the op function call. Also added unit test for search_virtual_remaining_leaves function task-5449083
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.