[IMP] empty #4928
Open
[IMP] empty #4928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding, it needs to be retargeted before it can be merged. |
added 2 commits
December 30, 2025 11:25
Steps to reproduce: Open an Employee form (via Payroll or Employees module). Navigate to the "Payroll" tab and locate the "Contract Overview" section. Observe that the "New Contract" button is visible even when no contract start date is present. Bug Cause: The button lacked a visibility attribute, causing it to render by default regardless of the state of the contract date fields. Solution: Added a conditional visibility attribute to the button so it remains hidden until a contract start date is defined. task - 5447340
…Types Steps to reproduce: 1. Go to Time Off -> Configuration -> Time Off Types. 2. Open any record. 3. Attempt to search or trigger a recomputation involving the "Virtual Remaining Leaves" field. 4. The system raises a TypeError. Bug Cause: The search method `_search_virtual_remaining_leaves` contains an internal `is_valid` helper function. This function attempts to call a comparison operator (e.g., `operator.gt`, `operator.lt`) by passing only a single argument. Since these operator methods require two arguments to perform a comparison, the process fails. Solution: Update the `is_valid` method to correctly pass the comparison value (the right-hand operand) to the operator, ensuring the search domain is evaluated correctly without crashing. task - 5449122
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.