Skip to content

add config to control if use put opt #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GroundWu wants to merge 3 commits into
base: hbase_2.0
Choose a base branch
from
+24 −4
Open

add config to control if use put opt #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
470d4df
add config to control if use put opt
GroundWu Jan 13, 2026
2a7e7a5
fix for comment
GroundWu Jan 13, 2026
5c250b6
modify config name
GroundWu Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/main/java/com/alipay/oceanbase/hbase/OHTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,11 @@ public class OHTable implements Table {
*/
private int maxKeyValueSize;

/**
* whether to enable put optimization path
*/
private boolean enablePutOptimization;

// i.e., doPut checks the writebuffer every X Puts.

/**
Expand Down Expand Up @@ -459,6 +464,8 @@ private void finishSetUp() {
DEFAULT_HBASE_HTABLE_PUT_WRITE_BUFFER_CHECK);
this.writeBufferSize = this.configuration.getLong(WRITE_BUFFER_SIZE_KEY,
WRITE_BUFFER_SIZE_DEFAULT);
this.enablePutOptimization = this.configuration.getBoolean(HBASE_HTABLE_USE_PUT_OPTIMIZATION,
HBASE_HTABLE_USE_PUT_OPTIMIZATION_DEFAULT);
}

public static OHConnectionConfiguration setUserDefinedNamespace(String tableNameString,
Expand Down Expand Up @@ -722,7 +729,7 @@ public void batch(final List<? extends Row> actions, final Object[] results) thr
} catch (Exception e) {
throw new IOException(tableNameString + " table occurred unexpected error." , e);
}
} else if (OHBaseFuncUtils.isAllPut(actions) && OHBaseFuncUtils.isHBasePutPefSupport(obTableClient)) {
} else if (OHBaseFuncUtils.isAllPut(actions) && OHBaseFuncUtils.isHBasePutPefSupport(obTableClient, enablePutOptimization)) {
// only support Put now
ObHbaseRequest request = buildHbaseRequest(actions);
try {
Expand Down Expand Up @@ -1253,15 +1260,15 @@ private void doPut(List<Put> puts) throws IOException {
// we need to periodically see if the writebuffer is full instead of waiting until the end of the List
n++;
if (n % putWriteBufferCheck == 0 && currentWriteBufferSize.get() > writeBufferSize) {
if (OHBaseFuncUtils.isHBasePutPefSupport(obTableClient)) {
if (OHBaseFuncUtils.isHBasePutPefSupport(obTableClient, enablePutOptimization)) {
flushCommitsV2();
} else {
flushCommits();
}
}
}
if (autoFlush || currentWriteBufferSize.get() > writeBufferSize) {
if (OHBaseFuncUtils.isHBasePutPefSupport(obTableClient)) {
if (OHBaseFuncUtils.isHBasePutPefSupport(obTableClient, enablePutOptimization)) {
flushCommitsV2();
} else {
flushCommits();
Expand Down
8 changes: 8 additions & 0 deletions src/main/java/com/alipay/oceanbase/hbase/constants/OHConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,12 @@ public final class OHConstants {
*/
public static final String HBASE_HTABLE_QUERY_HOT_ONLY = "hbase.htable.query.hot_only";

/**
* use to specify whether to enable put optimization path.
* Default is true (enabled).
*/
public static final String HBASE_HTABLE_USE_PUT_OPTIMIZATION = "hbase.htable.use.put.optimization";

/*-------------------------------------------------------------------------------------------------------------*/

/**
Expand Down Expand Up @@ -160,4 +166,6 @@ public final class OHConstants {

public static final int DEFAULT_SOCKET_TIMEOUT = 20000; // 20 seconds

public static final boolean HBASE_HTABLE_USE_PUT_OPTIMIZATION_DEFAULT = true;

}
7 changes: 6 additions & 1 deletion src/main/java/com/alipay/oceanbase/hbase/util/OHBaseFuncUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,12 @@ public static byte[][] extractFamilyFromQualifier(byte[] qualifier) throws Excep
return new byte[][] { family, newQualifier };
}

public static boolean isHBasePutPefSupport(ObTableClient tableClient) {
public static boolean isHBasePutPefSupport(ObTableClient tableClient, boolean enablePutOptimization) {
// If client-side optimization is disabled, return false directly
if (!enablePutOptimization) {
return false;
}

if (tableClient.isOdpMode()) {
// server version support and distributed capacity is enabled and odp version support
return ObGlobal.isHBasePutPerfSupport()
Expand Down