OxCaml: Fix missing parens for polymorphic parameters#1404
Merged
jonludlam merged 2 commits intoocaml:masterfrom Apr 15, 2026
Merged
OxCaml: Fix missing parens for polymorphic parameters#1404jonludlam merged 2 commits intoocaml:masterfrom
jonludlam merged 2 commits intoocaml:masterfrom
Conversation
Merged
Collaborator
Author
|
@jonludlam : Thanks for merging #1399! Hopefully, this PR should be an easy review now :) |
Member
|
Thanks, yes, this looks good, and we've finally got a green tick for passing tests too :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #1399: OxCaml polymorphic parameters were missing parentheses in Odoc rendering (note that polymorphic parameters were upstreamed ocaml/ocaml#13806 and are expected in OCaml 5.5).
(Only the last two commits are new: the first adds a test for OxCaml to check the support, the second patch fixes the missing parens.)
edit: marked as draft because we need to merge #1399 first, but otherwise the PR is ready to review!