Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if you want this in the context of your helper, but I modified it in my CI application in this manner. This code works very well for displaying a flash alert after a redirect but would not display the flash alert after a $this->load->view() call. In reading, it seems as though this may be by design, but I found my self needing to flash alerts after both scenarios. So, I merged your method with the method found on the CI wiki (http://codeigniter.com/wiki/Simple_FlashNotice_helper/) and ended up with a helper that works in both scenarios.
Also, I am utilizing Bootstrap 2 so my alerts are customized to utilize their built in CSS classes.
Also, thanks for writing this helper, I found it extremely useful and much nicer than the flash interface CI provides by default.