Open
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds TRAE installation docs and a Bash installer that links repository "skills" into either a global ( Changes
Sequence Diagram(s)sequenceDiagram
participant User as User
participant Script as scripts/install-trae.sh
participant Repo as Repository (skills/)
participant Target as TRAE_DIR (~/.trae or ./.trae)
User->>Script: run installer (--global / --project)
Script->>Repo: locate and list skills directory
Repo-->>Script: return skill subdirectories
Script->>Target: ensure TRAE_DIR and SKILLS_DIR exist
Script->>Target: create/remove symlinks for each skill -> `SKILLS_DIR/skill`
Script-->>User: completion or error messages
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (1)
docs/README.trae.md (1)
58-63: Addbashlanguage specifier to fenced code blocks (lines 58 and 68).Both blocks contain shell commands but lack a language tag, causing
markdownlintMD040 warnings.📝 Proposed fix
-``` +```bash cd ~/.trae/superpowers && git pull bash ~/.trae/superpowers/scripts/install-trae.sh```diff -``` +```bash 1. Verify the directory exists: `ls -la ~/.trae/skills` ...Also applies to: 65-71
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/README.trae.md` around lines 58 - 63, The two fenced code blocks in the "Updating" section and the subsequent example block are missing a language specifier, causing markdownlint MD040 warnings; update each opening triple-backtick to include "bash" (i.e., change ``` to ```bash) for the block containing "cd ~/.trae/superpowers && git pull..." and the block/example around the steps starting at the later block (lines referenced in the review), ensuring both fenced blocks are marked as bash so linters detect shell syntax.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.trae/INSTALL.md:
- Around line 28-33: The INSTALL.md example for project-local installation is
incorrect because scripts/install-trae.sh sets TRAE_DIR="$(pwd)/.trae", so
running the installer from ~/.trae/superpowers installs skills into the
superpowers repo; update the example code block to instruct users to cd into
their project first (e.g. cd /path/to/your/project) and run the installer by
path (e.g. bash ~/.trae/superpowers/scripts/install-trae.sh --project) so
TRAE_DIR correctly points at the user's project .trae directory; modify the
example in INSTALL.md accordingly.
- Around line 50-54: The uninstall step currently deletes the entire
~/.trae/skills folder; change it to remove only the symlinks the installer
created so user-owned skill directories are preserved — replace the `rm -rf
~/.trae/skills` instruction with guidance to delete only symbolic links inside
~/.trae/skills (e.g., using a find limited to depth 1 and filtering by type l or
by testing each entry’s target to confirm it points into the superpowers clone)
so only installer-created links are removed and real directories remain intact.
In `@docs/README.trae.md`:
- Around line 38-43: The documented example incorrectly instructs users to cd
into the superpowers clone before running scripts/install-trae.sh --project,
which causes --project to install into the clone’s .trae/skills/ folder; update
the README.trae.md example so the user stays in their target project directory
(e.g., cd /path/to/your/project) and invoke the installer by its path from the
clone (e.g., bash ~/.trae/superpowers/scripts/install-trae.sh --project) so the
--project flag installs into the current project’s .trae/skills/ instead of the
superpowers repo.
In `@README.md`:
- Around line 78-87: Move the entire "### TRAE" section (including the code
block `Fetch and follow instructions from
https://raw.githubusercontent.com/obra/superpowers/refs/heads/main/.trae/INSTALL.md`
and the "**Detailed docs:** [docs/README.trae.md](docs/README.trae.md)" link) so
it appears immediately before the "### Verify Installation" heading; ensure you
remove the duplicate trailing copy and preserve exact content and formatting of
the "### TRAE" heading, code block, and docs link.
---
Nitpick comments:
In `@docs/README.trae.md`:
- Around line 58-63: The two fenced code blocks in the "Updating" section and
the subsequent example block are missing a language specifier, causing
markdownlint MD040 warnings; update each opening triple-backtick to include
"bash" (i.e., change ``` to ```bash) for the block containing "cd
~/.trae/superpowers && git pull..." and the block/example around the steps
starting at the later block (lines referenced in the review), ensuring both
fenced blocks are marked as bash so linters detect shell syntax.
quangrau
force-pushed
the
feat/trae-installer
branch
from
a7300bb to
b0482a5
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/README.trae.md`:
- Around line 9-11: The fenced code block currently has no language identifier;
update the block delimiter to include the text language identifier by changing
the opening fence from ``` to ```text for the block that contains "Fetch and
follow instructions from
https://raw.githubusercontent.com/obra/superpowers/refs/heads/main/.trae/INSTALL.md"
(ensure the closing ``` remains) so the markdownlint MD040 warning is resolved.
In `@README.md`:
- Around line 75-77: Add the MD language identifier "text" to the fenced code
blocks that contain the plain-text AI prompt lines (the three bare
triple-backtick blocks used for the Codex prompt, the OpenCode prompt, and the
Quick Install/trae prompt) so each starts with ```text instead of just ```,
ensuring the blocks with the prompt "Fetch and follow instructions from
https://raw.githubusercontent.com/obra/superpowers/refs/heads/main/.trae/INSTALL.md"
and the analogous Codex/OpenCode prompt blocks are updated to silence MD040.
Comment on lines
+75
to
+77
| ``` | ||
| Fetch and follow instructions from https://raw.githubusercontent.com/obra/superpowers/refs/heads/main/.trae/INSTALL.md | ||
| ``` |
There was a problem hiding this comment.
Add text language identifier to fenced block (MD040).
Same as the Quick Install block in docs/README.trae.md — the content is a plain-text AI prompt. Note that the identical bare-block pattern also exists for the Codex (line 55) and OpenCode (line 65) sections; standardising all three to text would fully silence the MD040 warning across the file.
📝 Proposed fix
-```
+```text
Fetch and follow instructions from https://raw.githubusercontent.com/obra/superpowers/refs/heads/main/.trae/INSTALL.md</details>
<!-- suggestion_start -->
<details>
<summary>📝 Committable suggestion</summary>
> ‼️ **IMPORTANT**
> Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
```suggestion
🧰 Tools
🪛 markdownlint-cli2 (0.21.0)
[warning] 75-75: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@README.md` around lines 75 - 77, Add the MD language identifier "text" to the
fenced code blocks that contain the plain-text AI prompt lines (the three bare
triple-backtick blocks used for the Codex prompt, the OpenCode prompt, and the
Quick Install/trae prompt) so each starts with ```text instead of just ```,
ensuring the blocks with the prompt "Fetch and follow instructions from
https://raw.githubusercontent.com/obra/superpowers/refs/heads/main/.trae/INSTALL.md"
and the analogous Codex/OpenCode prompt blocks are updated to silence MD040.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Around line 80-81: Add a single blank line between the closing markdown code
fence and the "**Detailed docs:** [docs/README.trae.md]" line in README.md so
the TRAE section matches the other sections (insert one empty line after the ```
fence that precedes the "**Detailed docs:** [docs/README.trae.md]" entry).
---
Duplicate comments:
In `@README.md`:
- Around line 78-80: The fenced code block(s) in README.md that contain plain
text (e.g., the block with "Fetch and follow instructions from
https://raw.githubusercontent.com/obra/superpowers/refs/heads/main/.trae/INSTALL.md"
and the similar blocks in the Codex and OpenCode sections) are missing a
language identifier and trigger MD040; update each triple-backtick fence to
include a plain-text language tag (for example change ``` to ```text) for those
blocks so markdownlint no longer flags them.
79355c8 to
f2f95b0
Compare
quangrau
force-pushed
the
feat/trae-installer
branch
from
f2f95b0 to
6300032
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/README.trae.md`:
- Around line 22-26: Update the README step so the parent directory is created
before cloning: insert a command to create the target parent directory (e.g.,
run mkdir -p ~/.trae) immediately before the git clone line so that git clone
https://github.com/obra/superpowers.git ~/.trae/superpowers succeeds on fresh
environments where ~/.trae doesn't exist.
---
Duplicate comments:
In `@README.md`:
- Around line 78-80: The fenced code block containing the line "Fetch and follow
instructions from
https://raw.githubusercontent.com/obra/superpowers/refs/heads/main/.trae/INSTALL.md"
is missing a language identifier; update that triple-backtick block to include a
language token (use "text" to match the Cursor section) so the block becomes
```text ... ```, which will satisfy markdownlint MD040 and silence the warning.
Comment on lines
+22
to
+26
| 1. Clone the repo: | ||
|
|
||
| ```bash | ||
| git clone https://github.com/obra/superpowers.git ~/.trae/superpowers | ||
| ``` |
There was a problem hiding this comment.
git clone will fail if ~/.trae doesn't exist yet.
git clone creates the final path component (superpowers) but not intermediate parent directories. On a fresh TRAE environment where ~/.trae has never been created, step 1 will error with fatal: cannot mkdir '…/superpowers': No such file or directory.
📝 Proposed fix: create parent before cloning
1. Clone the repo:
```bash
+ mkdir -p ~/.trae
git clone https://github.com/obra/superpowers.git ~/.trae/superpowers
```🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@docs/README.trae.md` around lines 22 - 26, Update the README step so the
parent directory is created before cloning: insert a command to create the
target parent directory (e.g., run mkdir -p ~/.trae) immediately before the git
clone line so that git clone https://github.com/obra/superpowers.git
~/.trae/superpowers succeeds on fresh environments where ~/.trae doesn't exist.
Owner
|
Is there a way to do this without symlinking each skill? That's gonna be a nightmare for updates. |
obra
added
new-harness
Author
Thanks for the review! TRAE only discovers top-level skill folders under The installer is idempotent though, so updates are just git pull && bash install-trae.shI updated the README to clarify this. |
Author
|
@obra , ready for another round of review. Thanks! |
This was referenced Mar 29, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add TRAE support by introducing a safe “hub pattern” installer that symlinks each Superpowers skill into
~/.trae/skills/, plus TRAE installation docs consistent with existing Codex/OpenCode patterns.Motivation and Context
TRAE discovers skills as folders containing
SKILL.md, via:~/.trae/skills/.trae/skills/inside a projectThis change makes Superpowers skills available to TRAE in a way that:
git pullin the Superpowers clone (no copying)~/.trae/skills/What Changed
scripts/install-trae.sh:~/.trae/skillsis a real directory (converts from symlink if needed)./skills/<name>into~/.trae/skills/<name>.trae/INSTALL.mddocs/README.trae.mdREADME.mdupdated with a TRAE sectionHow Has This Been Tested?
scripts/install-trae.shwith an isolated temporaryHOME:~/.trae/skillsand links all repo skillsSKILL.mdskill count.Breaking Changes
None.
Types of changes
Checklist
https://modelcontextprotocol.ioAdditional context
This mirrors the “hub pattern” approach used for other platforms: link each skill directory individually rather than replacing the entire skills folder, so user-owned skills can coexist safely.
Summary by CodeRabbit
Documentation
Chores